Uploaded image for project: 'MariaDB Connector/J'
  1. MariaDB Connector/J
  2. CONJ-1053

Mark waffle-jna dependency optional in module descriptor

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.1.0, 3.1.1, 3.1.2
    • 3.5.1
    • java9
    • None

    Description

      As discussed in CONJ-1025, the dependency on waffle-jna is used only for the GSSAPI feature on Windows. Clients who want a smaller jar size can exclude the dependency using Maven or Gradle configuration.

      *JPMS*
      Excluding the dependency on waffle-jna works, – most of the time. However, the `module-info` of mariadb-java-client uses `requires waffle.jna`. This means, with JPMS enabled, waffle-jna must be present.

      The optionality of the waffle-jna dependency should be reflected in the JPMS module descriptor. The requires declaration should be requires static to properly reflect that waffle-jna is optional.

      It used to be `requires static`, but this commit changed it to `requires`. I'm not sure why. https://github.com/mariadb-corporation/mariadb-connector-j/commit/5ac67b2d17dcf4e0272781426d67299dedf5a377

      Attachments

        Activity

          People

            diego dupin Diego Dupin
            A248 Anand Beh
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.