Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-800

"dead" code in mariadb_rpl.c

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 3.4.7, 3.3.17
    • None
    • Replication/Binlog API
    • None

    Description

      There is piece of dead code in mariadb_rpl.c line 1769 and following:

            if (rpl_event->event_type >= WRITE_ROWS_COMPRESSED_EVENT) {
      		 
              return rpl_event;
      		 
              rpl_event->event.rows.compressed= 1;
      		 
              rpl_event->event.rows.type= rpl_event->event_type - WRITE_ROWS_COMPRESSED_EVENT;
      		 
            } else if (rpl_event->event_type >= WRITE_ROWS_COMPRESSED_EVENT_V1) {

      I can't remember but likely the return was not removed when manually testing. *ROWS_COMPRESSED_EVENT is not used in replication protocol anymore, so I think we can just remove this code block.

      Attachments

        Activity

          People

            georg Georg Richter
            georg Georg Richter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.