Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-766

Disable clang -Wcast-function-type-strict for makecontext

Details

    Description

      https://github.com/mariadb-corporation/mariadb-connector-c/pull/274

      makecontext has a defined prototype in ucontext.h that differs from its expected usage. Disable the clang warning for this function call.

      Modelled off the af4498b776b1703a00cbb4f86ead0d0e4f5332bb commit.

      3.3, 3.4+ only fix perfectly acceptable too.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDBF-741 Remove the gcc UBSAN builder to use the clang based UBSAN

          • Major - Major loss of function.
          • In Testing
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34348 MariaDB is violating clang-16 -Wcast-function-type-strict

          • Major - Major loss of function.
          • Closed

          Activity

            knielsen Kristian Nielsen added a comment -

            Reviewed the patch, it is ok.

            I think the warning can also be avoided by building with cmake arg -DWITH_BOOST_CONTEXT=ON, which should make it not use ucontext even in ASAN build.

            knielsen Kristian Nielsen added a comment - Reviewed the patch, it is ok. I think the warning can also be avoided by building with cmake arg -DWITH_BOOST_CONTEXT=ON , which should make it not use ucontext even in ASAN build.

            People

              georg Georg Richter
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.