Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-700

Compile fails with gcc-14.1.0 due to calloc errors

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.4.0
    • 3.1.23, 3.4.0
    • Tests
    • None
    • Linux

    Description

      Compile error is below.
      Fix is at https://github.com/mariadb-corporation/mariadb-connector-c/pull/247

      Executing (target): ninja 
      [144/145] Building C object unittest/libmariadb/CMakeFiles/bulk1.dir/bulk1.c.o
      FAILED: unittest/libmariadb/CMakeFiles/bulk1.dir/bulk1.c.o 
      /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -DHAVE_OPENSSL -DHAVE_REMOTEIO=1 -DHAVE_TLS -DLIBMARIADB -DMARIADB_MACHINE_TYPE=\"x86_64\" -DMARIADB_SYSTEM_TYPE=\"Linux\" -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/.x86_64-libreelec-linux-gnu/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/plugins/auth -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/plugins/compress -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/plugins/pvio -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/unittest/mytap -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/unittest/libmariadb -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -Wunused -Wlogical-op -Wno-uninitialized -Wall -Wextra -Wformat-security -Wno-init-self -Wwrite-strings -Wshift-count-overflow -Wdeclaration-after-statement -Wno-undef -Wno-unknown-pragmas -Wno-stringop-truncation -Werror  -DDBUG_OFF -MD -MT unittest/libmariadb/CMakeFiles/bulk1.dir/bulk1.c.o -MF unittest/libmariadb/CMakeFiles/bulk1.dir/bulk1.c.o.d -o unittest/libmariadb/CMakeFiles/bulk1.dir/bulk1.c.o -c /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/mariadb-connector-c-3.4.0/unittest/libmariadb/bulk1.c
      ../unittest/libmariadb/bulk1.c: In function 'bulk_with_unit_result_insert':
      ../unittest/libmariadb/bulk1.c:1129:43: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
       1129 |   lengths= (unsigned long *)calloc(sizeof(long), TEST_ARRAY_SIZE);
            |                                           ^~~~
      ../unittest/libmariadb/bulk1.c:1129:43: note: earlier argument should specify number of elements, later size of each element
      ../unittest/libmariadb/bulk1.c: In function 'bulk_with_unit_result_delete':
      ../unittest/libmariadb/bulk1.c:1254:39: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
       1254 |   vals= (unsigned int *)calloc(sizeof(int), 5);
            |                                       ^~~
      ../unittest/libmariadb/bulk1.c:1254:39: note: earlier argument should specify number of elements, later size of each element
      ../unittest/libmariadb/bulk1.c: In function 'bulk_with_unit_result_update':
      ../unittest/libmariadb/bulk1.c:1362:39: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
       1362 |   vals= (unsigned int *)calloc(sizeof(int), 5);
            |                                       ^~~
      ../unittest/libmariadb/bulk1.c:1362:39: note: earlier argument should specify number of elements, later size of each element
      cc1: all warnings being treated as errors
      ninja: build stopped: subcommand failed.
      

      Attachments

        Activity

          danblack Daniel Black added a comment - corrected in: https://github.com/mariadb-corporation/mariadb-connector-c/commit/dab59732d976f082101caea2501e21ae733da1a4 https://github.com/mariadb-corporation/mariadb-connector-c/commit/45179cffc4e5c0b9ee868e4bea4e258a2fdf633e https://github.com/mariadb-corporation/mariadb-connector-c/commit/11168e8798f1cc76bf693c67570bbedb5e161e0c

          The first commit that danblack listed was mine, for earlier branches of Connector/C. https://github.com/mariadb-corporation/mariadb-connector-c/commit/4681372f9cfe157752ff78520923c49e9af71e90 is an additional fix for the 3.4 branch.

          marko Marko Mäkelä added a comment - The first commit that danblack listed was mine, for earlier branches of Connector/C. https://github.com/mariadb-corporation/mariadb-connector-c/commit/4681372f9cfe157752ff78520923c49e9af71e90 is an additional fix for the 3.4 branch.

          People

            georg Georg Richter
            heitbaum Rudi Heitbaum
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.