Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-372

Fix str_to_TIME() parsing wrt performance.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 3.0.8
    • None
    • None

    Description

      currently, parsing str_to_TIME() is too complicated, and even embarassing in terms of performance

      https://github.com/MariaDB/mariadb-connector-c/blob/6545b1d194d5fd037844f7a0d93604fb4757cf41/libmariadb/ma_stmt_codec.c#L199

      Following calls inside it can and should be removed.
      alloca, memcpy, memset, strchr (x4), sscanf

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. CONC-378 MYSQL_DATA_TRUNCATED not always returned by mysql_stmt_fetch() for numeric type

          • Major - Major loss of function.
          • Closed

          Activity

            People

              wlad Vladislav Vaintroub
              wlad Vladislav Vaintroub
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 1d
                  1d

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.