Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-372

Fix str_to_TIME() parsing wrt performance.

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 3.0.8
    • None
    • None

    Description

      currently, parsing str_to_TIME() is too complicated, and even embarassing in terms of performance

      https://github.com/MariaDB/mariadb-connector-c/blob/6545b1d194d5fd037844f7a0d93604fb4757cf41/libmariadb/ma_stmt_codec.c#L199

      Following calls inside it can and should be removed.
      alloca, memcpy, memset, strchr (x4), sscanf

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Vladislav Vaintroub made transition -
            Open In Progress
            4d 22h 3m 1
            Vladislav Vaintroub made transition -
            In Progress Closed
            32s 1

            People

              wlad Vladislav Vaintroub
              wlad Vladislav Vaintroub
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.