Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-372

Fix str_to_TIME() parsing wrt performance.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Labels:
      None

      Description

      currently, parsing str_to_TIME() is too complicated, and even embarassing in terms of performance

      https://github.com/MariaDB/mariadb-connector-c/blob/6545b1d194d5fd037844f7a0d93604fb4757cf41/libmariadb/ma_stmt_codec.c#L199

      Following calls inside it can and should be removed.
      alloca, memcpy, memset, strchr (x4), sscanf

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              wlad Vladislav Vaintroub
              Reporter:
              wlad Vladislav Vaintroub
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: