[CONC-292] Erroneous malloc() result check in mariadb_dyncol_val_double() - Jira

XML

Word

Printable

mariadb_dyncol_val_double() function (defined in libmariadb/mariadb_dyncol.c) has the following code:

  if ((str= malloc(val->x.string.value.length + 1)))

    return ER_DYNCOL_RESOURCE;

  memcpy(str, val->x.string.value.str, val->x.string.value.length);

Shouldn't it be

  if ((str= malloc(val->x.string.value.length + 1)) == NULL)

...

instead?