Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9872

Add common optimized CRC32 function interface

Details

    • 10.2.1-1, 10.2.1-2, 10.2.2-1

    Description

      patch as per https://github.com/MariaDB/server/pull/170 adds optimized Power8 implemention for CRC32-IEEE to complement existing CRC32C.

      While I haven't included an implementation of an optimized CRC32-(IEEE) for intel, there is the following links that would enable this:

      Note the documentation mentions patents on CRC32 folding (which I haven't done).

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-19935 Create unified CRC-32 interface

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            svoj Sergey Vojtovich added a comment -

            serg, please review patch for this task (b6d7d5878eecc7f0cb76f8f99a9989686ff9715c).

            svoj Sergey Vojtovich added a comment - serg , please review patch for this task (b6d7d5878eecc7f0cb76f8f99a9989686ff9715c).
            svoj Sergey Vojtovich added a comment -

            upd: e252dae86392a2b50d647a380db36fb8b01bf405

            svoj Sergey Vojtovich added a comment - upd: e252dae86392a2b50d647a380db36fb8b01bf405
            danblack Daniel Black added a comment -

            svoj thanks, sorry I didn't get back to this sooner. If you need a hand let me know.

            danblack Daniel Black added a comment - svoj thanks, sorry I didn't get back to this sooner. If you need a hand let me know.
            svoj Sergey Vojtovich added a comment -

            danblack, no problem. It'd be nice if you could review this patch and let me know if I missed something.

            svoj Sergey Vojtovich added a comment - danblack , no problem. It'd be nice if you could review this patch and let me know if I missed something.
            svoj Sergey Vojtovich added a comment -

            Waiting for feedback.

            svoj Sergey Vojtovich added a comment - Waiting for feedback.
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            svoj Sergey Vojtovich added a comment -

            danblack, we're now getting failures like this:
            http://buildbot.askmonty.org/buildbot/builders/p8-xenial-bintar/builds/88/steps/test/logs/stdio

            I noticed that crc32-vpmsum sources differ in your PR. Did you also see these failures? Could you elaborate the difference?

            svoj Sergey Vojtovich added a comment - danblack , we're now getting failures like this: http://buildbot.askmonty.org/buildbot/builders/p8-xenial-bintar/builds/88/steps/test/logs/stdio I noticed that crc32-vpmsum sources differ in your PR. Did you also see these failures? Could you elaborate the difference?
            danblack Daniel Black added a comment -

            The crux of it is innodb uses CRC32C and the rest of MySQL (my_checksum) uses CRC32-IEEE.

            I'll patch in both implementations into the crc32-vpmsum library and then get my_checksum to point to the vpmsum crc32-ieee implementation

            danblack Daniel Black added a comment - The crux of it is innodb uses CRC32C and the rest of MySQL (my_checksum) uses CRC32-IEEE. I'll patch in both implementations into the crc32-vpmsum library and then get my_checksum to point to the vpmsum crc32-ieee implementation
            danblack Daniel Black added a comment -

            https://github.com/MariaDB/server/pull/211 - test case for SQL CRC32 function

            https://github.com/MariaDB/server/pull/210 - Add both versions of the CRC32 and adjust my_checksum to use the optimized version.

            danblack Daniel Black added a comment - https://github.com/MariaDB/server/pull/211 - test case for SQL CRC32 function https://github.com/MariaDB/server/pull/210 - Add both versions of the CRC32 and adjust my_checksum to use the optimized version.

            People

              svoj Sergey Vojtovich
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.