Details

    • Task
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 10.6.0
    • OTHER
    • None

    Description

      Distribute sys schema with MariaDB.

      Quite possibly it'll need some changes to work with MariaDB 10.6, so we'll need to clone the repo and apply our changes.
      In MySQL it's part of mysqld binary (for --initialize, I suppose). The repo is small, we can just include it in the server repo, as it's not a separate independent project really.

      Attachments

        Issue Links

          Activity

            serg Sergei Golubchik created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            colin Colin Charles added a comment -

            MariaDB compliant one from jcrespo – https://github.com/jynus/mysql-sys – this is something we could even merge into 10.1

            colin Colin Charles added a comment - MariaDB compliant one from jcrespo – https://github.com/jynus/mysql-sys – this is something we could even merge into 10.1
            leafonsword guo feng added a comment -

            Hope sys schema could come soon!

            leafonsword guo feng added a comment - Hope sys schema could come soon!
            ratzpo Rasmus Johansson (Inactive) made changes -
            Assignee Rasmus Johansson [ ratzpo ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.3 [ 22126 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic Link PT-61 [ 62166 ]
            serg Sergei Golubchik made changes -
            Assignee Rasmus Johansson [ ratzpo ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicentiu Ciorbaru [ cvicentiu ]
            danblack Daniel Black made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.3 [ 22126 ]
            julien.fritsch Julien Fritsch made changes -
            Epic Link PT-61 [ 62166 ] PT-76 [ 68557 ]
            julien.fritsch Julien Fritsch made changes -
            Support case ID 14986 not-14986
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.4 [ 22408 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic Link PT-76 [ 68557 ]
            cpanelkelli Kelli Grand added a comment -

            Hello,

            My name is Kelli Grand, and I'm a product owner at cPanel. We are very interested in this change and would like to see this case get resolved. Can you please provide me with an update on the status of this case?

            The impact of this problem is very high, from the number of tickets our customers create against it.

            cPanel & WHM currently ship with MySQL 5.7 with conversion paths to Maria 10.2 and 10.3. As of January this year, there was an update to MySQL 5.7 that includes these tables. mysql_ugprade script does not currently support these tables, and it is producing these kinds of problems for end users:

            • Inability to run mysqldump or mysqlbackup due to errors
            • phpMyAdmin will not load
            • Errors in the logs

            We have a lot of customers on older versions of MySQL at this time, and are actively encouraging them to update. In the future when we no longer support MySQL 5.6, there will be even more customers experiencing this problem if they choose to migrate to MariaDB.

            cpanelkelli Kelli Grand added a comment - Hello, My name is Kelli Grand, and I'm a product owner at cPanel. We are very interested in this change and would like to see this case get resolved. Can you please provide me with an update on the status of this case? The impact of this problem is very high, from the number of tickets our customers create against it. cPanel & WHM currently ship with MySQL 5.7 with conversion paths to Maria 10.2 and 10.3. As of January this year, there was an update to MySQL 5.7 that includes these tables. mysql_ugprade script does not currently support these tables, and it is producing these kinds of problems for end users: Inability to run mysqldump or mysqlbackup due to errors phpMyAdmin will not load Errors in the logs We have a lot of customers on older versions of MySQL at this time, and are actively encouraging them to update. In the future when we no longer support MySQL 5.6, there will be even more customers experiencing this problem if they choose to migrate to MariaDB.
            jcrespo Jaime Crespo added a comment -

            @Kelli I am not involved with MariaDB development, but I can help with a workaround. Colin linked above my patch for 10.1. We use it at Wikipedia for all our servers, as sys/performance_schema is key for us to do proper monitoring and profiling. I will soon review it to update it to the latest MySQL code base (at least for those features that it is feasible, and are not a hard dependency on MySQL new features. For migrations, old sys schema should be deleted and a MariaDB compatible one should be used instead, as MariaDB doesn't have things like UUID, certain metrics and there could be issues with the new data dictionary, among other differences. I of course will offer the patch to MariaDB developers if they want to bundle it by default.

            I think it would be a great idea for mysql_upgrade (on MariaDB) to detect this issue and tried to patch or reload the sys schema from a compatible one.

            jcrespo Jaime Crespo added a comment - @Kelli I am not involved with MariaDB development, but I can help with a workaround. Colin linked above my patch for 10.1. We use it at Wikipedia for all our servers, as sys/performance_schema is key for us to do proper monitoring and profiling. I will soon review it to update it to the latest MySQL code base (at least for those features that it is feasible, and are not a hard dependency on MySQL new features. For migrations, old sys schema should be deleted and a MariaDB compatible one should be used instead, as MariaDB doesn't have things like UUID, certain metrics and there could be issues with the new data dictionary, among other differences. I of course will offer the patch to MariaDB developers if they want to bundle it by default. I think it would be a great idea for mysql_upgrade (on MariaDB) to detect this issue and tried to patch or reload the sys schema from a compatible one.
            ralf.gebhardt Ralf Gebhardt made changes -
            cpanelkelli Kelli Grand added a comment -

            Thank you @Jaime for the suggestion. This, or something like it could be a path we take as a last resort, if we don't see any action from MariaDB on this case.

            cpanelkelli Kelli Grand added a comment - Thank you @Jaime for the suggestion. This, or something like it could be a path we take as a last resort, if we don't see any action from MariaDB on this case.
            karll Karl Levik added a comment -

            FromDual has recently been doing some work porting the sys schema to MariaDB:
            https://fromdual.com/mariadb-sys-schema.

            karll Karl Levik added a comment - FromDual has recently been doing some work porting the sys schema to MariaDB: https://fromdual.com/mariadb-sys-schema .
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Vicențiu Ciorbaru [ cvicentiu ] Ralf Gebhardt [ ralf.gebhardt@mariadb.com ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] Julius Goryavsky [ sysprg ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.5 [ 23123 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Julius Goryavsky [ sysprg ]
            julien.fritsch Julien Fritsch made changes -
            Fix Version/s 10.6 [ 24028 ]
            julien.fritsch Julien Fritsch made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            wlad Vladislav Vaintroub made changes -
            Assignee Vladislav Vaintroub [ wlad ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.6 [ 24028 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            serg Sergei Golubchik made changes -
            Description distribute sys schema with MariaDB Distribute sys schema with MariaDB.

            Quite possibly it'll need some changes to work with MariaDB 10.6, so we'll need to clone the repo and apply our changes.
            In MySQL it's part of mysqld binary (for --initialize, I suppose). The repo is small, we can just include it in the server repo, as it's not a separate independent project really.
            nunop Nuno added a comment -

            karll It gives an error when I try on a MariaDB 10.5 installation. Funny how they say in that page "Please try out MariaDB sys Schema, find bugs, describe how to provoke the problem and report those bugs on GitHub", yet their GitHub repo isn't accepting any Issues...

            nunop Nuno added a comment - karll It gives an error when I try on a MariaDB 10.5 installation. Funny how they say in that page "Please try out MariaDB sys Schema, find bugs, describe how to provoke the problem and report those bugs on GitHub", yet their GitHub repo isn't accepting any Issues...
            danblack Daniel Black added a comment -

            I did only provide oli a cross version compatible solution 2 days ago https://github.com/FromDual/mariadb-sys/pull/2

            danblack Daniel Black added a comment - I did only provide oli a cross version compatible solution 2 days ago https://github.com/FromDual/mariadb-sys/pull/2
            danblack Daniel Black made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            wlad Vladislav Vaintroub made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]

            Alexey, please review the current bb-10.6-sysschema

            wlad Vladislav Vaintroub added a comment - Alexey, please review the current bb-10.6-sysschema
            wlad Vladislav Vaintroub made changes -
            Assignee Vladislav Vaintroub [ wlad ] Aleksey Midenkov [ midenok ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            midenok Aleksey Midenkov added a comment - - edited

            There should be server option to switch SYS schema initialization on/off. Other test suites should run server without SYS schema and their results should not be affected. We do not want to enable SYS schema by default, do we? Users who need it will add corresponding option to their config files. Users who don't need it will not be dissatisfied by an unwanted entry in SHOW DATABASES.

            Please tweak a little bit README.md file to reflect current state of things regarding the installation.

            Otherwise looks good to me.

            midenok Aleksey Midenkov added a comment - - edited There should be server option to switch SYS schema initialization on/off. Other test suites should run server without SYS schema and their results should not be affected. We do not want to enable SYS schema by default, do we? Users who need it will add corresponding option to their config files. Users who don't need it will not be dissatisfied by an unwanted entry in SHOW DATABASES. Please tweak a little bit README.md file to reflect current state of things regarding the installation. Otherwise looks good to me.
            midenok Aleksey Midenkov made changes -
            Assignee Aleksey Midenkov [ midenok ] Vladislav Vaintroub [ wlad ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            wlad Vladislav Vaintroub added a comment - - edited

            We do want to enable sys schema by default, just like others do. There is no way to disable it in MySQL 8.0

            Let me quote https://dev.mysql.com/doc/refman/8.0/en/sys-schema.html
            "
            For new installations, the sys schema is installed by default during data directory initialization if you use mysqld with the --initialize or --initialize-insecure option. If this is not desired, you can drop the sys schema manually after initialization if it is unneeded."

            wlad Vladislav Vaintroub added a comment - - edited We do want to enable sys schema by default, just like others do. There is no way to disable it in MySQL 8.0 Let me quote https://dev.mysql.com/doc/refman/8.0/en/sys-schema.html " For new installations, the sys schema is installed by default during data directory initialization if you use mysqld with the --initialize or --initialize-insecure option. If this is not desired, you can drop the sys schema manually after initialization if it is unneeded."
            ralf.gebhardt Ralf Gebhardt added a comment -

            The performance schema plugin is loaded by default with load option "FORCED", so it makes sense to have the sys schema installed by default, too

            ralf.gebhardt Ralf Gebhardt added a comment - The performance schema plugin is loaded by default with load option "FORCED", so it makes sense to have the sys schema installed by default, too
            wlad Vladislav Vaintroub made changes -
            issue.field.resolutiondate 2021-03-23 08:58:07.0 2021-03-23 08:58:07.369
            wlad Vladislav Vaintroub made changes -
            Component/s OTHER [ 10125 ]
            Fix Version/s 10.6.0 [ 24431 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            Labels ServiceNow
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            Labels ServiceNow 76qDvLB8Gju6Hs7nk3VY3EX42G795W5z
            serg Sergei Golubchik made changes -
            Labels 76qDvLB8Gju6Hs7nk3VY3EX42G795W5z
            marko Marko Mäkelä made changes -
            wlad Vladislav Vaintroub made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 72438 ] MariaDB v4 [ 132719 ]
            anel Anel Husakovic made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 201658 175184 109784
            Zendesk active tickets 201658

            People

              wlad Vladislav Vaintroub
              serg Sergei Golubchik
              Votes:
              21 Vote for this issue
              Watchers:
              26 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.