Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8883

more cross-compiling fixes

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL)
    • 10.0.22, 10.1.9
    • Compiling
    • None
    • 10.0.22

    Description

      See patches from this thread

      1. XtraDB aborts compilation when it cannot be compiled (unsupported system), even if XtraDB is disabled from cmake command line.
      2. InnoDB relies on CHECK_C_SOURCE_RUNS which doesn't work when cross-compiling

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-9002 Build failure when crosscompiling for arm without atomics

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            Sylvain Sylvain Raybaud added a comment -

            Hi

            It seems BR2_ARCH_HAS_ATOMICS cannot be used, because for example on 32bits architectures some atomic operations may not be available even though BR2_ARCH_HAS_ATOMICS is set to true. Therefore your solution should be used.

            However I just realised that CHECK_C_SOURCE_RUNS should never be invoked by this script in buildroot because it's enclosed in

            IF(NOT CMAKE_CROSSCOMPILING)
            [...]
            ENDIF

            (https://github.com/MariaDB/server/blob/10.1/storage/innobase/CMakeLists.txt, line #75).

            Is -DCMAKE_CROSSCOMPILING supposed to passed when invoking cmake or is it supposed to be determined automatically?

            Sylvain Sylvain Raybaud added a comment - Hi It seems BR2_ARCH_HAS_ATOMICS cannot be used, because for example on 32bits architectures some atomic operations may not be available even though BR2_ARCH_HAS_ATOMICS is set to true. Therefore your solution should be used. However I just realised that CHECK_C_SOURCE_RUNS should never be invoked by this script in buildroot because it's enclosed in IF(NOT CMAKE_CROSSCOMPILING) [...] ENDIF ( https://github.com/MariaDB/server/blob/10.1/storage/innobase/CMakeLists.txt , line #75). Is -DCMAKE_CROSSCOMPILING supposed to passed when invoking cmake or is it supposed to be determined automatically?
            serg Sergei Golubchik added a comment -

            I've fixed the "XtraDB not supported" error (it won't be issued if XtraDB is disabled).
            Won't do anything about CHECK_C_SOURCE_RUNS because they're under IF(NOT CMAKE_CROSSCOMPILING).

            According to https://cmake.org/cmake/help/v3.0/variable/CMAKE_CROSSCOMPILING.html the variable CMAKE_CROSSCOMPILING) is set by CMake automatically.

            serg Sergei Golubchik added a comment - I've fixed the "XtraDB not supported" error (it won't be issued if XtraDB is disabled). Won't do anything about CHECK_C_SOURCE_RUNS because they're under IF(NOT CMAKE_CROSSCOMPILING) . According to https://cmake.org/cmake/help/v3.0/variable/CMAKE_CROSSCOMPILING.html the variable CMAKE_CROSSCOMPILING) is set by CMake automatically.
            Sylvain Sylvain Raybaud added a comment -

            Hi

            Thanks for the fix!

            When CMAKE_CROSSCOMPILING is set these tests are skipped indeed and HAVE_IB_GCC_ATOMIC_BUILTINS is not set. It triggers another build failure, at least when crosscompiling for arm in buildroot, that I've filed under MDEV-9002: https://mariadb.atlassian.net/browse/MDEV-9002

            Cheers,

            Sylvain

            Sylvain Sylvain Raybaud added a comment - Hi Thanks for the fix! When CMAKE_CROSSCOMPILING is set these tests are skipped indeed and HAVE_IB_GCC_ATOMIC_BUILTINS is not set. It triggers another build failure, at least when crosscompiling for arm in buildroot, that I've filed under MDEV-9002 : https://mariadb.atlassian.net/browse/MDEV-9002 Cheers, Sylvain
            Sylvain Sylvain Raybaud added a comment - - edited

            I propose the attached patch (the idea of which was suggested by serg) to be able to automatically check for atomic intrinsics event when cross-compiling. mariadb-galera-02-fix_innodb_cmakelist.patch

            Sylvain Sylvain Raybaud added a comment - - edited I propose the attached patch (the idea of which was suggested by serg ) to be able to automatically check for atomic intrinsics event when cross-compiling. mariadb-galera-02-fix_innodb_cmakelist.patch
            serg Sergei Golubchik added a comment -

            Thanks, I've done that too (not your patch verbatim, but similar).

            serg Sergei Golubchik added a comment - Thanks, I've done that too (not your patch verbatim, but similar).

            People

              serg Sergei Golubchik
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.