Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8831

enforce_storage_engine doesn't block table creation on other nodes (galera cluster)

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.7
    • 10.1.8
    • Galera
    • ubuntu server 15.04 64bits

    Description

      I set enforce_storage_engine to InnoDB and disable Myisam replication on all nodes of my cluster.

      When I try to create a Myisam table on a node, I logically get this error : Unknown storage engine 'MyISAM' and the table isn't created on this node.
      But it has been created on all other nodes! In the end, this table exists on every nodes of the cluster but one.

      Attachments

        Activity

          Patch attached.

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - Patch attached.

          Ok to push.

          jplindst Jan Lindström (Inactive) added a comment - Ok to push.

          nirbhay_c, why a failed CREATE TABLE statement is replicated at all?

          serg Sergei Golubchik added a comment - nirbhay_c , why a failed CREATE TABLE statement is replicated at all?

          serg because, Galera replicates DDL during parsing (WSREP_TO_ISOLATION_BEGIN).

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - serg because, Galera replicates DDL during parsing (WSREP_TO_ISOLATION_BEGIN).

          nirbhay_c, and what happens if the table cannot be created? Like, table already exists, table exists in the InnoDB tablespace, unsupported combination of values for table options, whatever.

          serg Sergei Golubchik added a comment - nirbhay_c , and what happens if the table cannot be created? Like, table already exists, table exists in the InnoDB tablespace, unsupported combination of values for table options, whatever.

          serg In that case, the DDL is expected to fail on all the nodes.

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - serg In that case, the DDL is expected to fail on all the nodes.
          nirbhay_c Nirbhay Choubey (Inactive) added a comment - https://github.com/MariaDB/server/commit/38f3b99d469ab90f07287577d05e48928de720d4

          People

            nirbhay_c Nirbhay Choubey (Inactive)
            ronan Ronan GORAIN
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.