Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8455

Make explicit_defaults_for_timestamp dynamic

Details

    • Task
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • None
    • Temporal Types
    • None

    Description

      MDEV-3929 will merge a patch from MySQL that added a read-only variable explicit_defaults_for_timestamp.

      This task will make explicit_defaults_for_timestamp dynamic and replication safe.

      Monty suggested the following regarding replication of explicit_defaults_for_timestamp:

      ok, the easy way to do this would be:
      Change SELECT_DISTINCT from 1 to (1ULL << 39)
      Add - OPTION_explicit_defaults_for_timestamp as 1
      Add OPTION_explicit_defaults_for_timestamp to OPTIONS_WRITTEN_TO_BIN_LOG
      In Query_log_event::do_apply_event set explicit_defaults_for_timestamp if OPTION_explicit_defaults_for_timestamp is set
      That should help ensure:

      • If you replicate from mariadb to mariadb, the slave will follow the master
      • If you replicate from MySQL to MariaDB, you have to have the same setting for MySQL and MariaDB
        Not much we can do for the second case, but the first case is the important one

      Attachments

        Issue Links

          Activity

            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            Priority Major [ 3 ] Critical [ 2 ]
            elenst Elena Stepanova made changes -
            Issue Type Bug [ 1 ] Task [ 3 ]
            bar Alexander Barkov made changes -
            Summary Make --explicit-defaults-for-timestamp dynamic Make explicit_defaults_for_timestamp dynamic
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Priority Critical [ 2 ] Major [ 3 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.1 [ 16100 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Alexander Barkov [ bar ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 70602 ] MariaDB v4 [ 130367 ]

            People

              Unassigned Unassigned
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.