Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8317

[PATCH] Possible overflowing a buffer in strncat

Details

    Description

      Our static analysis tool complained about possible buffer overflow. Haven't checked how probable it is to happen, but it would be good to fix it either attached way or to replace stncats with strncpys.

      Attachments

        Issue Links

          is part of

          Bug - A problem which impairs or prevents the functions of the product. MDEV-8379 SUSE mariadb patches

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            miska Michal Hrusecky created issue -
            elenst Elena Stepanova added a comment -

            bertrandop,
            If it applies to 10.0 too, please feel free to adjust the 'Fix version' accordingly.

            elenst Elena Stepanova added a comment - bertrandop , If it applies to 10.0 too, please feel free to adjust the 'Fix version' accordingly.
            elenst Elena Stepanova made changes -
            Field Original Value New Value
            Fix Version/s 10.1 [ 16100 ]
            Assignee Olivier Bertrand [ bertrandop ]
            Priority Minor [ 4 ] Major [ 3 ]
            Summary Possible overflowing a buffer in strncat [PATCH] Possible overflowing a buffer in strncat
            serg Sergei Golubchik made changes -
            Fix Version/s 10.0 [ 16000 ]
            svoj Sergey Vojtovich made changes -
            danblack Daniel Black made changes -
            Labels patch
            danblack Daniel Black made changes -
            Attachment mariadb-10.0.22-tabxml-bufferoverflowstrncat.patch [ 40407 ]
            bertrandop Olivier Bertrand added a comment -

            Thanks for raising this problem and providing patches.
            They will be applied with some typo modifications.
            Note that in newer versions, the 10.1 tabxml.cpp is identical to the 10.0 one.

            bertrandop Olivier Bertrand added a comment - Thanks for raising this problem and providing patches. They will be applied with some typo modifications. Note that in newer versions, the 10.1 tabxml.cpp is identical to the 10.0 one.
            bertrandop Olivier Bertrand made changes -
            Fix Version/s 10.0.23 [ 20401 ]
            Fix Version/s 10.1.9 [ 20301 ]
            Fix Version/s 10.0 [ 16000 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            bertrandop Olivier Bertrand added a comment - - edited

            Why am I only aware today of a problem raised last june?

            bertrandop Olivier Bertrand added a comment - - edited Why am I only aware today of a problem raised last june?
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 69911 ] MariaDB v4 [ 149270 ]

            People

              bertrandop Olivier Bertrand
              miska Michal Hrusecky
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.