Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8032

[PATCH] audit plugin - csv output broken

Details

    • 5.5.44

    Description

      since the audit file output is csv formatted, special characters like newline or tab should be replaced on the query. this replacement is done on querys with passwords (escape_string_hide_passwords) but not on casual escape_string()

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          h0nIg Hans-Joachim Kliemeck created issue -
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 5.5 [ 15800 ]
          Assignee Alexey Botchkov [ holyfoot ]
          Priority Minor [ 4 ] Major [ 3 ]
          Summary audit plugin - csv output broken [PATCH] audit plugin - csv output broken
          h0nIg Hans-Joachim Kliemeck added a comment -

          created pull request https://github.com/MariaDB/server/pull/45

          h0nIg Hans-Joachim Kliemeck added a comment - created pull request https://github.com/MariaDB/server/pull/45
          danblack Daniel Black added a comment -

          Could you add a test to mysql-test/suite/plugins/t/server_audit.test to cover this case?

          danblack Daniel Black added a comment - Could you add a test to mysql-test/suite/plugins/t/server_audit.test to cover this case?
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 60629 ] MariaDB v3 [ 64950 ]
          serg Sergei Golubchik made changes -
          Sprint Sprint 1 [ 4 ]
          holyfoot Alexey Botchkov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          holyfoot Alexey Botchkov added a comment -

          Thanks Hans-Joachim for noticing!
          fixing patch http://lists.askmonty.org/pipermail/commits/2015-June/008009.html

          holyfoot Alexey Botchkov added a comment - Thanks Hans-Joachim for noticing! fixing patch http://lists.askmonty.org/pipermail/commits/2015-June/008009.html
          holyfoot Alexey Botchkov made changes -
          Fix Version/s 5.5.44 [ 19100 ]
          Fix Version/s 5.5 [ 15800 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 64950 ] MariaDB v4 [ 149080 ]

          People

            holyfoot Alexey Botchkov
            h0nIg Hans-Joachim Kliemeck
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.