[MDEV-759] LP:998340 - Valgrind complains on simple selects containing expression DAY(FROM_UNIXTIME(-1)) - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Trivial
Resolution: Fixed
Affects Version/s: 5.2.12, 5.1.62
Fix Version/s: 5.1.67, 5.2.14
Component/s: None
Labels:
- Launchpad

Description

The following test case makes valgrind complain when running mariadb-5.1:

SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1)));

SELECT LEFT('1', DAY(FROM_UNIXTIME(-1)));

SELECT RIGHT('1', DAY(FROM_UNIXTIME(-1)));

SELECT REPEAT('1', DAY(FROM_UNIXTIME(-1)));

SELECT RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');

SELECT LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');

CREATE TABLE t1

SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1))) AS f1,

       LEFT('1', DAY(FROM_UNIXTIME(-1))) AS f2,

       RIGHT('1', DAY(FROM_UNIXTIME(-1))) AS f3,

       REPEAT('1', DAY(FROM_UNIXTIME(-1))) AS f4,

       RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f5,

       LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f6;

SHOW CREATE TABLE t1;

DROP TABLE t1;

(see also bug##12634989 from mysql-trunk)

The complains are like this:

==24162== Conditional jump or move depends on uninitialised value(s)

==24162==    at 0x622A1A: Item_func_substr::fix_length_and_dec() (item_strfunc.cc:1273)

==24162==    by 0x5EF4B7: Item_func::fix_fields(THD*, Item**) (item_func.cc:205)

==24162==    by 0x61E3DA: Item_str_func::fix_fields(THD*, Item**) (item_strfunc.cc:67)

==24162==    by 0x70BE1B: setup_fields(THD*, Item**, List<Item>&, enum_mark_columns, List<Item>*, bool) (sql_base.cc:7714)

==24162==    by 0x71F07B: JOIN::prepare(Item***, TABLE_LIST*, unsigned int, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, st_select_lex*, st_select_lex_unit*) (sql_select.cc:530)

==24162==    by 0x7268A7: mysql_select(THD*, Item***, TABLE_LIST*, unsigned int, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) (sql_select.cc:2545)

==24162==    by 0x71E818: handle_select(THD*, st_lex*, select_result*, unsigned long) (sql_select.cc:280)

==24162==    by 0x6BD119: execute_sqlcom_select(THD*, TABLE_LIST*) (sql_parse.cc:5241)

==24162==    by 0x6B4232: mysql_execute_command(THD*) (sql_parse.cc:2380)

==24162==    by 0x6BF845: mysql_parse(THD*, char*, unsigned int, char const**) (sql_parse.cc:6216)

==24162==    by 0x6B1B30: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1294)

==24162==    by 0x6B0AE0: do_command(THD*) (sql_parse.cc:906)

==24162==    by 0x6AD563: handle_one_connection (sql_connect.cc:1208)

==24162==    by 0x5D16A4E: start_thread (in /lib64/libpthread-2.11.2.so)

Most probably we have the same problem in other versions of MariaDB

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

LPexportBug998340.xml
2012-10-03 11:32
5 kB
Rasmus Johansson

Activity

Ascending order - Click to sort in descending order

Igor Babaev (Inactive) created issue - 2012-05-12 06:36

Rasmus Johansson (Inactive) added a comment - 2012-05-12 07:05

Launchpad bug id: 998340

Rasmus Johansson (Inactive) added a comment - 2012-05-12 07:05 Launchpad bug id: 998340

Rasmus Johansson (Inactive) made changes - 2012-10-04 11:35

Field	Original Value	New Value
Labels		Launchpad

Rasmus Johansson (Inactive) made changes - 2012-10-04 13:14

Key	~~IMT-7762~~	~~MDEV-759~~
Project	ImportTest [ 10200 ]	MariaDB Development [ 10000 ]
Workflow	jira [ 21411 ]	defaullt [ 21603 ]

Elena Stepanova made changes - 2012-11-22 02:43

Affects Version/s		5.1.62 [ 10701 ]
Affects Version/s		5.2.12 [ 10702 ]

Elena Stepanova made changes - 2012-11-22 02:43

Fix Version/s

5.2.13 [ 10800 ]

Sergei Golubchik made changes - 2012-11-26 17:44

Fix Version/s		5.2.14 [ 12101 ]
Fix Version/s	5.2.13 [ 10800 ]

Sergei Golubchik made changes - 2012-12-27 19:58

Description

The following test case makes valgrind complain when running mariadb-5.1:

SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1)));
SELECT LEFT('1', DAY(FROM_UNIXTIME(-1)));
SELECT RIGHT('1', DAY(FROM_UNIXTIME(-1)));
SELECT REPEAT('1', DAY(FROM_UNIXTIME(-1)));
SELECT RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');
SELECT LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');

CREATE TABLE t1
SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1))) AS f1,
       LEFT('1', DAY(FROM_UNIXTIME(-1))) AS f2,
       RIGHT('1', DAY(FROM_UNIXTIME(-1))) AS f3,
       REPEAT('1', DAY(FROM_UNIXTIME(-1))) AS f4,
       RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f5,
       LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f6;
SHOW CREATE TABLE t1;
DROP TABLE t1;

(see also bug##12634989 from mysql-trunk)

The complains are like this:

==24162== Conditional jump or move depends on uninitialised value(s)
==24162== at 0x622A1A: Item_func_substr::fix_length_and_dec() (item_strfunc.cc:1273)
==24162== by 0x5EF4B7: Item_func::fix_fields(THD*, Item**) (item_func.cc:205)
==24162== by 0x61E3DA: Item_str_func::fix_fields(THD*, Item**) (item_strfunc.cc:67)
==24162== by 0x70BE1B: setup_fields(THD*, Item**, List<Item>&, enum_mark_columns, List<Item>*, bool) (sql_base.cc:7714)
==24162== by 0x71F07B: JOIN::prepare(Item***, TABLE_LIST*, unsigned int, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, st_select_lex*, st_select_lex_unit*) (sql_select.cc:530)
==24162== by 0x7268A7: mysql_select(THD*, Item***, TABLE_LIST*, unsigned int, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) (sql_select.cc:2545)
==24162== by 0x71E818: handle_select(THD*, st_lex*, select_result*, unsigned long) (sql_select.cc:280)
==24162== by 0x6BD119: execute_sqlcom_select(THD*, TABLE_LIST*) (sql_parse.cc:5241)
==24162== by 0x6B4232: mysql_execute_command(THD*) (sql_parse.cc:2380)
==24162== by 0x6BF845: mysql_parse(THD*, char*, unsigned int, char const**) (sql_parse.cc:6216)
==24162== by 0x6B1B30: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1294)
==24162== by 0x6B0AE0: do_command(THD*) (sql_parse.cc:906)
==24162== by 0x6AD563: handle_one_connection (sql_connect.cc:1208)
==24162== by 0x5D16A4E: start_thread (in /lib64/libpthread-2.11.2.so)

Most probably we have the same problem in other versions of MariaDB

The following test case makes valgrind complain when running mariadb-5.1:
{code:sql}
SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1)));
SELECT LEFT('1', DAY(FROM_UNIXTIME(-1)));
SELECT RIGHT('1', DAY(FROM_UNIXTIME(-1)));
SELECT REPEAT('1', DAY(FROM_UNIXTIME(-1)));
SELECT RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');
SELECT LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?');

CREATE TABLE t1
SELECT SUBSTRING('1', DAY(FROM_UNIXTIME(-1))) AS f1,
       LEFT('1', DAY(FROM_UNIXTIME(-1))) AS f2,
       RIGHT('1', DAY(FROM_UNIXTIME(-1))) AS f3,
       REPEAT('1', DAY(FROM_UNIXTIME(-1))) AS f4,
       RPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f5,
       LPAD('hi', DAY(FROM_UNIXTIME(-1)),'?') AS f6;
SHOW CREATE TABLE t1;
DROP TABLE t1;
{code}
(see also bug##12634989 from mysql-trunk)

The complains are like this:
{noformat}
==24162== Conditional jump or move depends on uninitialised value(s)
==24162== at 0x622A1A: Item_func_substr::fix_length_and_dec() (item_strfunc.cc:1273)
==24162== by 0x5EF4B7: Item_func::fix_fields(THD*, Item**) (item_func.cc:205)
==24162== by 0x61E3DA: Item_str_func::fix_fields(THD*, Item**) (item_strfunc.cc:67)
==24162== by 0x70BE1B: setup_fields(THD*, Item**, List<Item>&, enum_mark_columns, List<Item>*, bool) (sql_base.cc:7714)
==24162== by 0x71F07B: JOIN::prepare(Item***, TABLE_LIST*, unsigned int, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, st_select_lex*, st_select_lex_unit*) (sql_select.cc:530)
==24162== by 0x7268A7: mysql_select(THD*, Item***, TABLE_LIST*, unsigned int, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) (sql_select.cc:2545)
==24162== by 0x71E818: handle_select(THD*, st_lex*, select_result*, unsigned long) (sql_select.cc:280)
==24162== by 0x6BD119: execute_sqlcom_select(THD*, TABLE_LIST*) (sql_parse.cc:5241)
==24162== by 0x6B4232: mysql_execute_command(THD*) (sql_parse.cc:2380)
==24162== by 0x6BF845: mysql_parse(THD*, char*, unsigned int, char const**) (sql_parse.cc:6216)
==24162== by 0x6B1B30: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1294)
==24162== by 0x6B0AE0: do_command(THD*) (sql_parse.cc:906)
==24162== by 0x6AD563: handle_one_connection (sql_connect.cc:1208)
==24162== by 0x5D16A4E: start_thread (in /lib64/libpthread-2.11.2.so)
{noformat}
Most probably we have the same problem in other versions of MariaDB

Sergei Golubchik added a comment - 2012-12-27 20:00

Elena, could you please check whether it applies to 5.3+ ?

Sergei Golubchik added a comment - 2012-12-27 20:00 Elena, could you please check whether it applies to 5.3+ ?

Sergei Golubchik made changes - 2012-12-27 20:00

Assignee

Alexey Botchkov [ holyfoot ]

Elena Stepanova [ elenst ]

Elena Stepanova added a comment - 2012-12-27 20:47

Could not reproduce it on current MariaDB 5.3, 5.5, 10.0-base.
Still reproducible on 5.2 (revno 3194).

On 5.3 tried compile-pentium-valgrind-max-no-ndb and the provided test case with different values of optimizer_switch (in case it matters): default, all OFF values, and optimizer_switch from 5.2, no valgrind warnings with either.

Elena Stepanova added a comment - 2012-12-27 20:47 Could not reproduce it on current MariaDB 5.3, 5.5, 10.0-base. Still reproducible on 5.2 (revno 3194). On 5.3 tried compile-pentium-valgrind-max-no-ndb and the provided test case with different values of optimizer_switch (in case it matters): default, all OFF values, and optimizer_switch from 5.2, no valgrind warnings with either.

Elena Stepanova made changes - 2012-12-27 20:47

Assignee

Elena Stepanova [ elenst ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2013-01-25 12:35

Priority

Major [ 3 ]

Trivial [ 5 ]

Sergei Golubchik made changes - 2013-01-25 12:35

Assignee

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2013-01-25 12:39

Assignee

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2013-01-25 12:50

Status

Open [ 1 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2013-01-25 13:05

Fix Version/s

5.1.67 [ 12100 ]

Sergei Golubchik added a comment - 2013-01-25 14:20

pushed in 5.1

Sergei Golubchik added a comment - 2013-01-25 14:20 pushed in 5.1

Sergei Golubchik made changes - 2013-01-25 14:20

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2014-06-13 15:07

Workflow

defaullt [ 21603 ]

MariaDB v2 [ 46449 ]

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 46449 ]

MariaDB v3 [ 67153 ]

Sergei Golubchik made changes - 2021-12-06 21:38

Workflow

MariaDB v3 [ 67153 ]

MariaDB v4 [ 146148 ]

People

Assignee:: Sergei Golubchik

Reporter:: Igor Babaev (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2012-05-12 06:36

Updated:: 2013-01-25 14:20

Resolved:: 2013-01-25 14:20

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Activity

People

Dates

Git Integration