Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7560

wsrep* tests depend on the version of galera library, the dependency should be checked

Details

    Description

      I am getting the following failure on my local machine while running wsrep.variables:

      CURRENT_TEST: wsrep.variables
      --- /data/repo/git/10.1/mysql-test/suite/wsrep/r/variables.result	2015-01-27 15:49:28.000000000 +0300
      +++ /data/repo/git/10.1/mysql-test/suite/wsrep/r/variables.reject	2015-02-08 00:37:27.000000000 +0300
      @@ -23,7 +23,6 @@
       wsrep_causal_reads	#
       wsrep_cert_deps_distance	#
       wsrep_cert_index_size	#
      -wsrep_cert_interval	#
       wsrep_cluster_conf_id	#
       wsrep_cluster_size	#
       wsrep_cluster_state_uuid	#
      @@ -74,7 +73,6 @@
       wsrep_causal_reads	#
       wsrep_cert_deps_distance	#
       wsrep_cert_index_size	#
      -wsrep_cert_interval	#
       wsrep_cluster_conf_id	#
       wsrep_cluster_size	#
       wsrep_cluster_state_uuid	#
       
      mysqltest: Result length mismatch

      I assume it's because the installed version of galera doesn't have this variable (is it right?)
      If so, the tests should check the version of the library in use and tests should be skipped if the version is too low.

      Attachments

        Activity

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - 10.1: https://github.com/MariaDB/server/commit/4c191de323be14993947197d84057c4d32fda0e6 10.0-galera: https://github.com/MariaDB/server/commit/aa2904a7f4014cd4790086a2512dc39b533b2a8a
          danblack Daniel Black added a comment -

          Matching against a fixed galera version isn't appropriate as we keep bumping it (https://mariadb.com/kb/en/meta/galera-versions/).

          Attached pull request (https://github.com/MariaDB/server/pull/351) does a proper version comparison.

          danblack Daniel Black added a comment - Matching against a fixed galera version isn't appropriate as we keep bumping it ( https://mariadb.com/kb/en/meta/galera-versions/ ). Attached pull request ( https://github.com/MariaDB/server/pull/351 ) does a proper version comparison.

          People

            sachin.setiya.007 Sachin Setiya (Inactive)
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.