[MDEV-7025] ANALYZE SELECT/INSERT/UPDATE/DELETE from a view does not check access permissions on the underlying table - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.1.1
Fix Version/s: 10.1.4
Component/s: Views
Labels:
- analyze-stmt

Description

Test case
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;

--disconnect con1
--connection default

drop user u1@localhost;
drop database db;

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

Same for INSERT, UPDATE, DELETE.

Attachments

Issue Links

relates to

MDEV-406 ANALYZE $stmt

Closed

MDEV-6382 ANALYZE $stmt and security

Closed

MDEV-6422 More testing for ANALYZE stmt and JSON

Closed

Activity

Ascending order - Click to sort in descending order

Elena Stepanova created issue - 2014-11-05 16:24

Elena Stepanova made changes - 2014-11-05 16:24

Field	Original Value	New Value
Link		This issue relates to ~~MDEV-406~~ [ ~~MDEV-406~~ ]

Elena Stepanova made changes - 2014-11-05 16:24

Link

This issue relates to ~~MDEV-6382~~ [ ~~MDEV-6382~~ ]

Elena Stepanova made changes - 2014-11-05 16:24

Link

This issue relates to ~~MDEV-6422~~ [ ~~MDEV-6422~~ ]

Elena Stepanova made changes - 2014-11-05 16:24

Description

{code:sql|title=Test case}
--enable_connect_log

create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

{code:sql|title=Test case}
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

Elena Stepanova made changes - 2014-11-05 16:30

Description

{code:sql|title=Test case}
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

{code:sql|title=Test case}
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;

--disconnect con1
--connection default

drop user u1@localhost;
drop database db;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

Elena Stepanova made changes - 2014-11-05 17:18

Summary

ANALYZE SELECT from a view does not check access permissions to the underlying table

ANALYZE SELECT/INSERT/UPDATE/DELETE from a view does not check access permissions to the underlying table

Elena Stepanova made changes - 2014-11-05 17:21

Description

{code:sql|title=Test case}
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;

--disconnect con1
--connection default

drop user u1@localhost;
drop database db;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

{code:sql|title=Test case}
--enable_connect_log
create database db;
use db;
create table t1 (i int, c varchar(8));
insert into t1 values (1,'foo'),(2,'bar'),(3,'baz'),(4,'qux');
create view v1 as select * from t1 where i > 1;
grant all on db.v1 to u1@localhost;

--connect (con1,localhost,u1,,)

--error ER_TABLEACCESS_DENIED_ERROR
select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
explain select * from db.t1;
--error ER_TABLEACCESS_DENIED_ERROR
analyze select * from db.t1;

select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
explain select * from db.v1;
--error ER_VIEW_NO_EXPLAIN
analyze select * from db.v1;

--disconnect con1
--connection default

drop user u1@localhost;
drop database db;
{code}

The last statement should fail just like the previous one does, but it succeeds (and reveals the underlying t1 table in the output).

Same for INSERT, UPDATE, DELETE.

Elena Stepanova made changes - 2014-11-05 17:21

Summary

ANALYZE SELECT/INSERT/UPDATE/DELETE from a view does not check access permissions to the underlying table

ANALYZE SELECT/INSERT/UPDATE/DELETE from a view does not check access permissions on the underlying table

Sergei Petrunia made changes - 2015-03-03 16:29

Assignee

Sergei Petrunia [ psergey ]

Vicentiu Ciorbaru [ cvicentiu ]

Vicențiu Ciorbaru made changes - 2015-03-04 13:56

Status

Open [ 1 ]

In Progress [ 3 ]

Vicențiu Ciorbaru made changes - 2015-03-04 13:56

Assignee	Vicentiu Ciorbaru [ cvicentiu ]	Sergei Petrunia [ psergey ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Petrunia added a comment - 2015-03-04 17:12

review feedback provided over email

Sergei Petrunia added a comment - 2015-03-04 17:12 review feedback provided over email

Sergei Petrunia made changes - 2015-03-04 17:12

Assignee	Sergei Petrunia [ psergey ]	Vicentiu Ciorbaru [ cvicentiu ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Vicențiu Ciorbaru added a comment - 2015-03-10 22:01

Added access checks to be performed for the analyze statement, similarly to how it was done for EXPLAIN and SHOW VIEW.

Fixed with:
0ed57e34c76ffa5e457e1abb402ada6352fb52b2

Vicențiu Ciorbaru added a comment - 2015-03-10 22:01 Added access checks to be performed for the analyze statement, similarly to how it was done for EXPLAIN and SHOW VIEW. Fixed with: 0ed57e34c76ffa5e457e1abb402ada6352fb52b2

Vicențiu Ciorbaru made changes - 2015-03-10 22:01

Fix Version/s		10.1.4 [ 18400 ]
Fix Version/s	10.1 [ 16100 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2015-03-16 11:15

Component/s

OTHER [ 10125 ]

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 58211 ]

MariaDB v3 [ 66959 ]

Sergei Golubchik made changes - 2021-12-06 21:40

Workflow

MariaDB v3 [ 66959 ]

MariaDB v4 [ 148414 ]

People

Assignee:: Vicențiu Ciorbaru

Reporter:: Elena Stepanova

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2014-11-05 16:24

Updated:: 2015-03-16 11:15

Resolved:: 2015-03-10 22:01

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration