[MDEV-6533] MySQL Bug#72718 - CACHE_LINE_SIZE in innodb should be 128 on POWER - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.0.15
Component/s: Storage Engine - InnoDB, Storage Engine - XtraDB
Labels:
None

Description

The following patch is suggested by Stewart Smith:

Define CACHE_LINE_SIZE in ut0counter.h to 128 on POWER

Index: mysql-5.6.17/storage/innobase/include/ut0counter.h

===================================================================

--- mysql-5.6.17.orig/storage/innobase/include/ut0counter.h

+++ mysql-5.6.17/storage/innobase/include/ut0counter.h

@@ -32,7 +32,11 @@ Created 2012/04/12 by Sunny Bains

 #include "os0thread.h"

 /** CPU cache line size */

+#ifdef __powerpc__

+#define CACHE_LINE_SIZE                128

+#else

 #define CACHE_LINE_SIZE                64

+#endif

 /** Default number of slots to use in ib_counter_t */

 #define IB_N_SLOTS             64

Attachments

Issue Links

is part of

MDEV-6530 Examine and apply Power8 patches suggested by Stewart Smith

Closed

relates to

MDEV-9857 CACHE_LINE_SIZE in innodb should be 128 on POWER

Closed

links to

MySQL BUG#72718

Activity

Ascending order - Click to sort in descending order

Sergey Vojtovich created issue - 2014-08-05 17:37

Sergey Vojtovich made changes - 2014-08-05 17:37

Field	Original Value	New Value
Link		This issue is part of ~~MDEV-6530~~ [ ~~MDEV-6530~~ ]

Sergey Vojtovich made changes - 2014-08-05 17:38

Remote Link

This issue links to "MySQL BUG#72718 (Web Link)" [ 18804 ]

Sergey Vojtovich added a comment - 2014-08-05 17:39

We need to double check proper way of determining CPU cache line size. Plus XtraDB had one more source file with CACHE_LINE_SIZE definition/

Sergey Vojtovich added a comment - 2014-08-05 17:39 We need to double check proper way of determining CPU cache line size. Plus XtraDB had one more source file with CACHE_LINE_SIZE definition/

Sergey Vojtovich made changes - 2014-08-05 18:06

Description

{noformat}
Define CACHE_LINE_SIZE in ut0counter.h to 128 on POWER

Index: mysql-5.6.17/storage/innobase/include/ut0counter.h
===================================================================
--- mysql-5.6.17.orig/storage/innobase/include/ut0counter.h
+++ mysql-5.6.17/storage/innobase/include/ut0counter.h
@@ -32,7 +32,11 @@ Created 2012/04/12 by Sunny Bains
#include "os0thread.h"

/** CPU cache line size */
+#ifdef __powerpc__
+#define CACHE_LINE_SIZE 128
+#else
#define CACHE_LINE_SIZE 64
+#endif

/** Default number of slots to use in ib_counter_t */
#define IB_N_SLOTS 64
{noformat}

The following patch is suggested by Stewart Smith:
{noformat}
Define CACHE_LINE_SIZE in ut0counter.h to 128 on POWER

Index: mysql-5.6.17/storage/innobase/include/ut0counter.h
===================================================================
--- mysql-5.6.17.orig/storage/innobase/include/ut0counter.h
+++ mysql-5.6.17/storage/innobase/include/ut0counter.h
@@ -32,7 +32,11 @@ Created 2012/04/12 by Sunny Bains
#include "os0thread.h"

/** CPU cache line size */
+#ifdef __powerpc__
+#define CACHE_LINE_SIZE 128
+#else
#define CACHE_LINE_SIZE 64
+#endif

/** Default number of slots to use in ib_counter_t */
#define IB_N_SLOTS 64
{noformat}

Michael Widenius made changes - 2014-08-05 18:07

Status

Open [ 1 ]

In Review [ 10002 ]

Michael Widenius added a comment - 2014-08-05 18:08

ok to push for now
Just add to the comment that the change was suggested by stewart smith.

Michael Widenius added a comment - 2014-08-05 18:08 ok to push for now Just add to the comment that the change was suggested by stewart smith.

Michael Widenius added a comment - 2014-08-05 18:08

ok to push after comment change

Michael Widenius added a comment - 2014-08-05 18:08 ok to push after comment change

Michael Widenius made changes - 2014-08-05 18:08

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Sergey Vojtovich added a comment - 2014-08-28 10:25

Adjusting cache line size is the right thing in theory. But in practice we didn't see any noteworthy throughput increase with this patch. We'll get back to this patch when we have proof that smaller cache line size negatively affects performance.

Sergey Vojtovich added a comment - 2014-08-28 10:25 Adjusting cache line size is the right thing in theory. But in practice we didn't see any noteworthy throughput increase with this patch. We'll get back to this patch when we have proof that smaller cache line size negatively affects performance.

Sergey Vojtovich made changes - 2014-08-28 10:25

Fix Version/s		N/A [ 14700 ]
Fix Version/s	10.0 [ 16000 ]
Resolution		Cannot Reproduce [ 5 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Sergey Vojtovich made changes - 2014-10-03 16:35

Assignee

Michael Widenius [ monty ]

Sergey Vojtovich [ svoj ]

Sergey Vojtovich added a comment - 2014-10-03 16:36

Axel reported that this patch gives ~5% throughput increase @ 20cores.

Sergey Vojtovich added a comment - 2014-10-03 16:36 Axel reported that this patch gives ~5% throughput increase @ 20cores.

Sergey Vojtovich made changes - 2014-10-03 16:36

Resolution	Cannot Reproduce [ 5 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Sergey Vojtovich added a comment - 2014-10-03 16:40

revno: 4427

revision-id: svoj@mariadb.org-20141003133846-h7cjr7mbk653q450

parent: bar@mnogosearch.org-20141002114820-2jqqgtje33dx4679

committer: Sergey Vojtovich <svoj@mariadb.org>

branch nick: 10.0-mdev6533

timestamp: Fri 2014-10-03 17:38:46 +0400

message:

  MDEV-6533 - MySQL Bug#72718 - CACHE_LINE_SIZE in innodb should be 128 on POWER

  This patch is suggested by Stewart Smith.

  Define CACHE_LINE_SIZE to 128 on POWER.

Sergey Vojtovich added a comment - 2014-10-03 16:40 revno: 4427 revision-id: svoj@mariadb.org-20141003133846-h7cjr7mbk653q450 parent: bar@mnogosearch.org-20141002114820-2jqqgtje33dx4679 committer: Sergey Vojtovich <svoj@mariadb.org> branch nick: 10.0-mdev6533 timestamp: Fri 2014-10-03 17:38:46 +0400 message: MDEV-6533 - MySQL Bug#72718 - CACHE_LINE_SIZE in innodb should be 128 on POWER This patch is suggested by Stewart Smith. Define CACHE_LINE_SIZE to 128 on POWER.

Sergey Vojtovich made changes - 2014-10-03 16:40

Component/s		Storage Engine - InnoDB [ 10129 ]
Component/s		Storage Engine - XtraDB [ 10135 ]
Fix Version/s		10.0.15 [ 17300 ]
Fix Version/s	N/A [ 14700 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 52105 ]

MariaDB v3 [ 64939 ]

Daniel Black added a comment - 2016-01-12 02:14

similar: https://github.com/mysql/mysql-server/pull/37 for aarch64 too

Daniel Black added a comment - 2016-01-12 02:14 similar: https://github.com/mysql/mysql-server/pull/37 for aarch64 too

Daniel Black made changes - 2016-04-01 02:05

Link

This issue relates to ~~MDEV-9857~~ [ ~~MDEV-9857~~ ]

Sergei Golubchik made changes - 2021-12-06 21:22

Workflow

MariaDB v3 [ 64939 ]

MariaDB v4 [ 132383 ]

People

Assignee:: Sergey Vojtovich

Reporter:: Sergey Vojtovich

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2014-08-05 17:37

Updated:: 2016-04-01 02:05

Resolved:: 2014-10-03 16:40

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration