Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5620

CMake option to compile against an external PCRE library

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 10.0.8
    • 10.0.9
    • None
    • None

    Description

      Under terms of MDEV-5304 we upgraded PCRE to 8.34
      but did not add a CMake options to compile against an
      external PCRE library.
      We should eventually add a CMake option.

      The problem is that using an external PCRE is dangerous
      because of a possible stack overrun, which we fix in the bundled
      PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.

      There are some options:
      a. wait for the PCRE team to add some built-in means to watch the stack
      b. use the current PCRE version and check the pattern against
      nested parenthesis every time we call pcre_compile().

      Attachments

        Activity

          bar Alexander Barkov created issue -
          bar Alexander Barkov made changes -
          Field Original Value New Value
          Description Under terms of MDEV-5304 we upgraded PCRE to 8.34
          but did not add a CMake options to compile against an
          external PCRE library.
          We should eventually add a CMake option.

          The problem is that using an external PCRE is dangerous
          because of a possible stack overrun, which we fix in the bundled
          PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.

          There are some options:
          a. wait for the PCRE team to add some build-in means to watch the stack
          b. use the current version and check the pattern against
            nested parenthesis every time we call pcre_compile().
          Under terms of MDEV-5304 we upgraded PCRE to 8.34
          but did not add a CMake options to compile against an
          external PCRE library.
          We should eventually add a CMake option.

          The problem is that using an external PCRE is dangerous
          because of a possible stack overrun, which we fix in the bundled
          PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.

          There are some options:
          a. wait for the PCRE team to add some built-in means to watch the stack
          b. use the current version and check the pattern against
            nested parenthesis every time we call pcre_compile().
          bar Alexander Barkov made changes -
          Description Under terms of MDEV-5304 we upgraded PCRE to 8.34
          but did not add a CMake options to compile against an
          external PCRE library.
          We should eventually add a CMake option.

          The problem is that using an external PCRE is dangerous
          because of a possible stack overrun, which we fix in the bundled
          PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.

          There are some options:
          a. wait for the PCRE team to add some built-in means to watch the stack
          b. use the current version and check the pattern against
            nested parenthesis every time we call pcre_compile().
          Under terms of MDEV-5304 we upgraded PCRE to 8.34
          but did not add a CMake options to compile against an
          external PCRE library.
          We should eventually add a CMake option.

          The problem is that using an external PCRE is dangerous
          because of a possible stack overrun, which we fix in the bundled
          PCRE with the patch pcre/maria-patches/pcre_stack_guard.diff.

          There are some options:
          a. wait for the PCRE team to add some built-in means to watch the stack
          b. use the current PCRE version and check the pattern against
            nested parenthesis every time we call pcre_compile().
          serg Sergei Golubchik made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          serg Sergei Golubchik made changes -
          grknight Brian Evans made changes -
          serg Sergei Golubchik made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          serg Sergei Golubchik made changes -
          Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 34206 ] MariaDB v2 [ 42807 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 42807 ] MariaDB v3 [ 61817 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 61817 ] MariaDB v4 [ 147470 ]

          People

            serg Sergei Golubchik
            bar Alexander Barkov
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.