Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5127

Test suite test file_contents fails in Slackware Linux

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 5.5.33a
    • 5.5.34
    • None
    • None
    • Slackware Linux 14.0 + kernel 3.10.4

    Description

      The test fails because file_contents.test does not know where to look for INFO_SRC and INFO_BIN.

      The attached patch enables it to recognise a Slackware system. I tried not to break any other tests but it's been a while since I touched Perl

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-5342 CLONE - Test suite test file_contents fails in Slackware Linux

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            duncan_roe Duncan Roe created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            Fix Version/s 5.5.34 [ 13700 ]
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            serg Sergei Golubchik made changes -
            Assignee Sergey Vojtovich [ svoj ]
            duncan_roe Duncan Roe made changes -
            Attachment better_file_contents.test.diff.gz [ 23908 ]
            duncan_roe Duncan Roe added a comment -

            I uploaded a better patch that also works for mariadb-10.x. Simple diff:

            diff -r1.2 -r1.3
            14c14
            < + $dir_docs = glob "$dir_bin/doc/mariadb-?.*";
            —
            > + $dir_docs = glob "$dir_bin/doc/mariadb-[0-9]*";

            The reason for using glob at all was that when it was a mysql patch, there were other candidate directories like
            mysql-connector-c++-1.1.3 etc.

            duncan_roe Duncan Roe added a comment - I uploaded a better patch that also works for mariadb-10.x. Simple diff: diff -r1.2 -r1.3 14c14 < + $dir_docs = glob "$dir_bin/doc/mariadb-?.*"; — > + $dir_docs = glob "$dir_bin/doc/mariadb- [0-9] *"; The reason for using glob at all was that when it was a mysql patch, there were other candidate directories like mysql-connector-c++-1.1.3 etc.
            svoj Sergey Vojtovich added a comment -

            Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131021122924-o9wgpxqcv74mhlrv

            svoj Sergey Vojtovich added a comment - Fixed in 5.5.34, revision-id: svoj@mariadb.org-20131021122924-o9wgpxqcv74mhlrv
            svoj Sergey Vojtovich made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            svoj Sergey Vojtovich added a comment -

            Duncan, thanks for your contribution. I pushed slightly modified fix to 5.5.34.

            svoj Sergey Vojtovich added a comment - Duncan, thanks for your contribution. I pushed slightly modified fix to 5.5.34.
            svoj Sergey Vojtovich made changes -
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 29256 ] MariaDB v2 [ 44123 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 44123 ] MariaDB v3 [ 63392 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 63392 ] MariaDB v4 [ 147117 ]

            People

              svoj Sergey Vojtovich
              duncan_roe Duncan Roe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.