Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-5085

Dynamic columns require inclusion of my_sys.h and my_global.h

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 10.0.6
    • 10.0.5
    • None
    • None
    • all

    Description

      Dynamic columns (ma_dyncol.h) uses structs DYNAMIC_STRING and LEX_STRING) which are included via my_sys.h and my_global.h.
      These files shouldn't be included in application programs (also my_global.h includes other files which aren't part of the binary distribution).

      How to fix:

      ma_dyncol.h

      		 
      #ifndef _my_sys_h
      		 
      +typedef struct st_dynamic_string
      		 
      +{
      		 
      +    char *str;
      		 
      +    size_t length,max_length,alloc_increment;
      		 
      +} DYNAMIC_STRING;
      		 
      +#endif
      		 
       
      		 
      +#ifndef MY_GLOBAL_INCLUDED
      		 
      +struct st_mysql_lex_string
      		 
      +{
      		 
      +  char *str;
      		 
      +  size_t length;
      		 
      +};
      		 
      +typedef struct st_mysql_lex_string MYSQL_LEX_STRING;
      		 
      +typedef struct st_mysql_lex_string LEX_STRING;
      		 
      +#endif

      Attachments

        Activity

          Transition Time In Source Status Execution Times
          Oleksandr Byelkin made transition -
          Open In Progress
          		3d 5h 51m 1
          Oleksandr Byelkin made transition -
          Stalled In Progress
          		2d 17h 32m 2
          Oleksandr Byelkin made transition -
          In Progress Stalled
          		17m 13s 3
          Oleksandr Byelkin made transition -
          Stalled Closed
          		17d 6h 56m 1

          People

            sanja Oleksandr Byelkin
            georg Georg Richter
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.