Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4824

userstats - wrong user statistics

Details

    Description

      At least bytes_received can be wrong. In function update_global_user_stats_with_user:

      user_stats->bytes_received+= (thd->org_status_var.bytes_received-
      		 
                                      thd->start_bytes_received);

      thd->start_bytes_received is set in do_command(), but it is not called if thd_prepare_connection() fails.

      cpu_time looks strange also...

      select USER, CONNECTED_TIME, BUSY_TIME, CPU_TIME, BYTES_RECEIVED from information_schema.user_statistics where user = 'cacti';
      		 
      +-------+----------------+--------------------+-------------------+---------------------+
      		 
      | USER  | CONNECTED_TIME | BUSY_TIME          | CPU_TIME          | BYTES_RECEIVED      |
      		 
      +-------+----------------+--------------------+-------------------+---------------------+
      		 
      | cacti |             46 | 0.3571019999999954 | 692552.4628808994 | 9223372036854775807 |
      		 
      +-------+----------------+--------------------+-------------------+---------------------+

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          pomyk Patryk Pomykalski created issue -
          pomyk Patryk Pomykalski added a comment -

          Also found valgrind warnings when running ./mtr main.connect -valgrind --mysqld=-userstat

          ==7422== Thread 5:
          ==7422== Conditional jump or move depends on uninitialised value(s)
          ==7422== at 0x81F30EA: THD::update_all_stats() (sql_class.cc:1314)
          ==7422== by 0x822E580: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1462)
          ==7422== by 0x822C467: do_command(THD*) (sql_parse.cc:794)
          ==7422== by 0x833033D: do_handle_one_connection(THD*) (sql_connect.cc:1266)
          ==7422== by 0x832FE84: handle_one_connection (sql_connect.cc:1181)
          ==7422== by 0x858B6BF: pfs_spawn_thread (pfs.cc:1015)
          ==7422== by 0x404296D: start_thread (pthread_create.c:300)
          ==7422== by 0x42B4A4D: clone (clone.S:130)
          ==7422== Conditional jump or move depends on uninitialised value(s)
          ==7422== at 0x81F311A: THD::update_all_stats() (sql_class.cc:1316)
          ==7422== by 0x822E580: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1462)
          ==7422== by 0x822C467: do_command(THD*) (sql_parse.cc:794)
          ==7422== by 0x833033D: do_handle_one_connection(THD*) (sql_connect.cc:1266)
          ==7422== by 0x832FE84: handle_one_connection (sql_connect.cc:1181)
          ==7422== by 0x858B6BF: pfs_spawn_thread (pfs.cc:1015)
          ==7422== by 0x404296D: start_thread (pthread_create.c:300)
          ==7422== by 0x42B4A4D: clone (clone.S:130)

          pomyk Patryk Pomykalski added a comment - Also found valgrind warnings when running ./mtr main.connect - valgrind --mysqld= -userstat ==7422== Thread 5: ==7422== Conditional jump or move depends on uninitialised value(s) ==7422== at 0x81F30EA: THD::update_all_stats() (sql_class.cc:1314) ==7422== by 0x822E580: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1462) ==7422== by 0x822C467: do_command(THD*) (sql_parse.cc:794) ==7422== by 0x833033D: do_handle_one_connection(THD*) (sql_connect.cc:1266) ==7422== by 0x832FE84: handle_one_connection (sql_connect.cc:1181) ==7422== by 0x858B6BF: pfs_spawn_thread (pfs.cc:1015) ==7422== by 0x404296D: start_thread (pthread_create.c:300) ==7422== by 0x42B4A4D: clone (clone.S:130) ==7422== Conditional jump or move depends on uninitialised value(s) ==7422== at 0x81F311A: THD::update_all_stats() (sql_class.cc:1316) ==7422== by 0x822E580: dispatch_command(enum_server_command, THD*, char*, unsigned int) (sql_parse.cc:1462) ==7422== by 0x822C467: do_command(THD*) (sql_parse.cc:794) ==7422== by 0x833033D: do_handle_one_connection(THD*) (sql_connect.cc:1266) ==7422== by 0x832FE84: handle_one_connection (sql_connect.cc:1181) ==7422== by 0x858B6BF: pfs_spawn_thread (pfs.cc:1015) ==7422== by 0x404296D: start_thread (pthread_create.c:300) ==7422== by 0x42B4A4D: clone (clone.S:130)
          elenst Elena Stepanova added a comment -

          The valgrind warning is reproducible as described on the current 5.5 tree built with BUILD/compile-pentium-valgrind-max-no-ndb. If it turns out to be unrelated to the wrong values problem, I can try to create a test case for that one.

          elenst Elena Stepanova added a comment - The valgrind warning is reproducible as described on the current 5.5 tree built with BUILD/compile-pentium-valgrind-max-no-ndb. If it turns out to be unrelated to the wrong values problem, I can try to create a test case for that one.
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          Fix Version/s 5.5.33 [ 13300 ]
          Assignee Sergei Golubchik [ serg ]
          elenst Elena Stepanova made changes -
          Labels user_statistics
          serg Sergei Golubchik made changes -
          Fix Version/s 5.5.34 [ 13500 ]
          Fix Version/s 5.5.33 [ 13300 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 5.5.34 [ 13700 ]
          Fix Version/s 5.5.33a [ 13500 ]
          serg Sergei Golubchik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 28301 ] MariaDB v2 [ 43394 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 43394 ] MariaDB v3 [ 62485 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 62485 ] MariaDB v4 [ 146892 ]

          People

            serg Sergei Golubchik
            pomyk Patryk Pomykalski
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.