Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4545

[PATCH] Fix an incorrect comparison in READ_INFO::terminator

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • 10.0.2, 5.5.31
    • 10.0.4, 5.5.32
    • None
    • None

    Description

      Please consider including the attached patch into MariaDB.
      The comparison being fixed could fail due to sign expansion of the terminator characters.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          sanja Oleksandr Byelkin added a comment -

          Pavel, under what license do we have these patches (as well as patches for in 4546 and 4547) ? If it's new BSD, could you say that explicitly, please?

          sanja Oleksandr Byelkin added a comment - Pavel, under what license do we have these patches (as well as patches for in 4546 and 4547) ? If it's new BSD, could you say that explicitly, please?
          sanja Oleksandr Byelkin added a comment -

          This was fixed in 5.5 (in a bit other patch but the problem fixed in the same way).

          sanja Oleksandr Byelkin added a comment - This was fixed in 5.5 (in a bit other patch but the problem fixed in the same way).
          sanja Oleksandr Byelkin added a comment -

          revno: 3823
          fixes bug: https://mariadb.atlassian.net/browse/MDEV-4718
          committer: Sergei Golubchik <sergii@pisem.net>
          branch nick: 5.5
          timestamp: Mon 2013-07-01 17:54:24 +0200
          message:
          MDEV-4718 Test "outfile_loaddata" fails on bigendian arches (ppc64)

          for field terminators, uchar was compared with char

          sanja Oleksandr Byelkin added a comment - revno: 3823 fixes bug: https://mariadb.atlassian.net/browse/MDEV-4718 committer: Sergei Golubchik <sergii@pisem.net> branch nick: 5.5 timestamp: Mon 2013-07-01 17:54:24 +0200 message: MDEV-4718 Test "outfile_loaddata" fails on bigendian arches (ppc64) for field terminators, uchar was compared with char
          sanja Oleksandr Byelkin added a comment -

          MDEV-4718

          sanja Oleksandr Byelkin added a comment - MDEV-4718
          pivanof Pavel Ivanov added a comment -

          All patches (including the patch here, in 4546 and 4547) are provided under the "New BSD" License by Google Inc.

          pivanof Pavel Ivanov added a comment - All patches (including the patch here, in 4546 and 4547) are provided under the "New BSD" License by Google Inc.

          People

            sanja Oleksandr Byelkin
            pivanof Pavel Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.