Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4476

mytop tracker

Details

    Description

      1. Document changes in mytop that are in MariaDB on KB
      2. Submit patches back to upstream mytop
      3. Propose removal of mytop from MariaDB (also if we ship, make sure perl-TermReadKey is Requires: )
      4. Potentially package MariaDB-mytop if upstream doesn't accept it

      Thread reference:
      https://lists.launchpad.net/maria-developers/msg05470.html

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-519 mariadb-client-5.5 conflicts with package mytop

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-3952 Incompatible change in MariaDB-5.5.28a-client rpm adds mytop when not in MariaDB-5.5.23-client (CentOS 5)

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #215

          Activity

            Ascending order - Click to sort in descending order
            View 16 older comments
            jb-boin Jean Weisbuch added a comment -

            New "minor" revision (1.99-maria3) : https://github.com/jb-boin/mariadb/commit/8c72d7235c213955f947744a051fd2027c262ba3

            In this revision, I mainly moved tests for server capabilities from the "main loop" to the beginning of the script so they are only executed once.

            The changelog :

            • The tests that checks if the server has INFORMATION_SCHEMA.PROCESSLIST, TIME_MS and STAGE support on the PROCESSLIST from the "main loop" that is executed at every refresh of the thread view to the beginning if the script to be executed only once.
            • The "GetQcacheSummary()" empty and unused function has been removed.
            jb-boin Jean Weisbuch added a comment - New "minor" revision (1.99-maria3) : https://github.com/jb-boin/mariadb/commit/8c72d7235c213955f947744a051fd2027c262ba3 In this revision, I mainly moved tests for server capabilities from the "main loop" to the beginning of the script so they are only executed once. The changelog : The tests that checks if the server has INFORMATION_SCHEMA.PROCESSLIST, TIME_MS and STAGE support on the PROCESSLIST from the "main loop" that is executed at every refresh of the thread view to the beginning if the script to be executed only once. The " GetQcacheSummary() " empty and unused function has been removed.
            anel Anel Husakovic added a comment -

            Pushed in 10.5 with commit c454b8964c10301d.
            Still we should document changes in this regard.

            anel Anel Husakovic added a comment - Pushed in 10.5 with commit c454b8964c10301d . Still we should document changes in this regard.
            otto Otto Kekäläinen added a comment -

            anel Could you take downstream patch https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and apply if upstream? It does not apply cleanly, somebody needs to decide which changes to take and how, and test that it works.

            In https://jira.mariadb.org/browse/MDEV-22552?focusedCommentId=155100&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-155100 Serg decided we shall keep shiping mytop and maintaining it, thus it would make sense to take in that patch and ensure our mytop if of the latest and best version.

            otto Otto Kekäläinen added a comment - anel Could you take downstream patch https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and apply if upstream? It does not apply cleanly, somebody needs to decide which changes to take and how, and test that it works. In https://jira.mariadb.org/browse/MDEV-22552?focusedCommentId=155100&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-155100 Serg decided we shall keep shiping mytop and maintaining it, thus it would make sense to take in that patch and ensure our mytop if of the latest and best version.
            otto Otto Kekäläinen added a comment -

            Seems most, but not all, changes carried in the Debian packaging repository to improve mytop were applied upstream and manually reviewing all the ones that were not applied (and deciding if they are needed or not) was too much work, so I simply dropped the whole patch in https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/cb2a1609e5693a79c541724798e434c8349d65f0.

            Hopefully somebody else has time to review https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and salvage any changes from there that still seem relevant.

            otto Otto Kekäläinen added a comment - Seems most, but not all, changes carried in the Debian packaging repository to improve mytop were applied upstream and manually reviewing all the ones that were not applied (and deciding if they are needed or not) was too much work, so I simply dropped the whole patch in https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/cb2a1609e5693a79c541724798e434c8349d65f0 . Hopefully somebody else has time to review https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and salvage any changes from there that still seem relevant.
            otto Otto Kekäläinen added a comment -

            Related Debian bug about the wish for somebody to maintain (again) mytop as a separate project/package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863968

            otto Otto Kekäläinen added a comment - Related Debian bug about the wish for somebody to maintain (again) mytop as a separate project/package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863968

            People

              anel Anel Husakovic
              colin Colin Charles
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.