1. Document changes in mytop that are in MariaDB on KB
2. Submit patches back to upstream mytop
3. Propose removal of mytop from MariaDB (also if we ship, make sure perl-TermReadKey is Requires: )
4. Potentially package MariaDB-mytop if upstream doesn't accept it
In this revision, I mainly moved tests for server capabilities from the "main loop" to the beginning of the script so they are only executed once.
The changelog :
The tests that checks if the server has INFORMATION_SCHEMA.PROCESSLIST, TIME_MS and STAGE support on the PROCESSLIST from the "main loop" that is executed at every refresh of the thread view to the beginning if the script to be executed only once.
The "GetQcacheSummary()" empty and unused function has been removed.
Jean Weisbuch
added a comment - New "minor" revision (1.99-maria3) : https://github.com/jb-boin/mariadb/commit/8c72d7235c213955f947744a051fd2027c262ba3
In this revision, I mainly moved tests for server capabilities from the "main loop" to the beginning of the script so they are only executed once.
The changelog :
The tests that checks if the server has INFORMATION_SCHEMA.PROCESSLIST, TIME_MS and STAGE support on the PROCESSLIST from the "main loop" that is executed at every refresh of the thread view to the beginning if the script to be executed only once.
The " GetQcacheSummary() " empty and unused function has been removed.
Otto Kekäläinen
added a comment - anel Could you take downstream patch https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and apply if upstream? It does not apply cleanly, somebody needs to decide which changes to take and how, and test that it works.
In https://jira.mariadb.org/browse/MDEV-22552?focusedCommentId=155100&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-155100 Serg decided we shall keep shiping mytop and maintaining it, thus it would make sense to take in that patch and ensure our mytop if of the latest and best version.
Otto Kekäläinen
added a comment - Seems most, but not all, changes carried in the Debian packaging repository to improve mytop were applied upstream and manually reviewing all the ones that were not applied (and deciding if they are needed or not) was too much work, so I simply dropped the whole patch in https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/cb2a1609e5693a79c541724798e434c8349d65f0 .
Hopefully somebody else has time to review https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/mytop-merge_src:mytop_improvements.patch and salvage any changes from there that still seem relevant.
Otto Kekäläinen
added a comment - Related Debian bug about the wish for somebody to maintain (again) mytop as a separate project/package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863968
People
Anel Husakovic
Colin Charles
Votes:
1Vote for this issue
Watchers:
7Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":1335.5,"ttfb":525.6999998092651,"pageVisibility":"visible","entityId":24032,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"3b21adc4-5b43-48d9-a73c-5cbe476a4684","navigationType":0,"readyForUser":1411.1999998092651,"redirectCount":0,"resourceLoadedEnd":1064.5,"resourceLoadedStart":534.2999997138977,"resourceTiming":[{"duration":191,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":534.2999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":534.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":725.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":191.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":534.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":534.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":725.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":391.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":534.7999997138977,"connectEnd":727.7999997138977,"connectStart":727.7999997138977,"domainLookupEnd":727.7999997138977,"domainLookupStart":727.7999997138977,"fetchStart":534.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":728.0999999046326,"responseEnd":926.0999999046326,"responseStart":741.0999999046326,"secureConnectionStart":727.7999997138977},{"duration":512.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":535.2999997138977,"connectEnd":535.2999997138977,"connectStart":535.2999997138977,"domainLookupEnd":535.2999997138977,"domainLookupStart":535.2999997138977,"fetchStart":535.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":729.0999999046326,"responseEnd":1048,"responseStart":743.3999996185303,"secureConnectionStart":535.2999997138977},{"duration":222.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":535.5,"connectEnd":535.5,"connectStart":535.5,"domainLookupEnd":535.5,"domainLookupStart":535.5,"fetchStart":535.5,"redirectEnd":0,"redirectStart":0,"requestStart":732.6999998092651,"responseEnd":758.3999996185303,"responseStart":754.8999996185303,"secureConnectionStart":535.5},{"duration":223.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":535.5999999046326,"connectEnd":535.5999999046326,"connectStart":535.5999999046326,"domainLookupEnd":535.5999999046326,"domainLookupStart":535.5999999046326,"fetchStart":535.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":732.8999996185303,"responseEnd":758.7999997138977,"responseStart":756.6999998092651,"secureConnectionStart":535.5999999046326},{"duration":199.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":535.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":535.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":735,"responseStart":0,"secureConnectionStart":0},{"duration":226.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":535.6999998092651,"connectEnd":535.6999998092651,"connectStart":535.6999998092651,"domainLookupEnd":535.6999998092651,"domainLookupStart":535.6999998092651,"fetchStart":535.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":736.3999996185303,"responseEnd":762.5999999046326,"responseStart":760.5,"secureConnectionStart":535.6999998092651},{"duration":227.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":535.7999997138977,"connectEnd":535.7999997138977,"connectStart":535.7999997138977,"domainLookupEnd":535.7999997138977,"domainLookupStart":535.7999997138977,"fetchStart":535.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":737.8999996185303,"responseEnd":763,"responseStart":760.8999996185303,"secureConnectionStart":535.7999997138977},{"duration":200.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":536,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":536,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":736.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":227.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":536.0999999046326,"connectEnd":536.0999999046326,"connectStart":536.0999999046326,"domainLookupEnd":536.0999999046326,"domainLookupStart":536.0999999046326,"fetchStart":536.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":738.6999998092651,"responseEnd":763.3999996185303,"responseStart":761.6999998092651,"secureConnectionStart":536.0999999046326},{"duration":526.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":538,"connectEnd":538,"connectStart":538,"domainLookupEnd":538,"domainLookupStart":538,"fetchStart":538,"redirectEnd":0,"redirectStart":0,"requestStart":1017.1999998092651,"responseEnd":1064.1999998092651,"responseStart":1060.6999998092651,"secureConnectionStart":538},{"duration":521,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":543.5,"connectEnd":543.5,"connectStart":543.5,"domainLookupEnd":543.5,"domainLookupStart":543.5,"fetchStart":543.5,"redirectEnd":0,"redirectStart":0,"requestStart":1018.8999996185303,"responseEnd":1064.5,"responseStart":1061.1999998092651,"secureConnectionStart":543.5},{"duration":202.09999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1057.6999998092651,"connectEnd":1057.6999998092651,"connectStart":1057.6999998092651,"domainLookupEnd":1057.6999998092651,"domainLookupStart":1057.6999998092651,"fetchStart":1057.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":1218.5999999046326,"responseEnd":1259.7999997138977,"responseStart":1258.2999997138977,"secureConnectionStart":1057.6999998092651},{"duration":214.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1291.0999999046326,"connectEnd":1291.0999999046326,"connectStart":1291.0999999046326,"domainLookupEnd":1291.0999999046326,"domainLookupStart":1291.0999999046326,"fetchStart":1291.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1469.5999999046326,"responseEnd":1506,"responseStart":1504.7999997138977,"secureConnectionStart":1291.0999999046326},{"duration":183.7000002861023,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1328.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1328.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1512.5999999046326,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":336,"responseStart":525,"responseEnd":543,"domLoading":529,"domInteractive":1508,"domContentLoadedEventStart":1508,"domContentLoadedEventEnd":1555,"domComplete":2158,"loadEventStart":2158,"loadEventEnd":2159,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1482},{"name":"bigPipe.sidebar-id.end","time":1482.7999997138977},{"name":"bigPipe.activity-panel-pipe-id.start","time":1482.8999996185303},{"name":"bigPipe.activity-panel-pipe-id.end","time":1484.5},{"name":"activityTabFullyLoaded","time":1579.5}],"measures":[],"correlationId":"2ca881bc6c41df","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":106,"dbReadsTimeInMs":12,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Task
Major
New "minor" revision (1.99-maria3) : https://github.com/jb-boin/mariadb/commit/8c72d7235c213955f947744a051fd2027c262ba3
In this revision, I mainly moved tests for server capabilities from the "main loop" to the beginning of the script so they are only executed once.
The changelog :