Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4398

use fallocate in InnoDB in 10.0

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.0.2, 10.0.3
    • None
    • None

    Description

      fallocate code is currently disabled in InnoDB in 10.0, because it triggers an assert. This needs to be fixed.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          serg Sergei Golubchik created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Summary use ftruncate in InnoDB in 10.0 use fallocate in InnoDB in 10.0
          serg Sergei Golubchik made changes -
          Description ftruncate code is currently disabled in InnoDB in 10.0, because it triggers an assert. This needs to be fixed. fallocate code is currently disabled in InnoDB in 10.0, because it triggers an assert. This needs to be fixed.
          serg Sergei Golubchik added a comment -

          now it's disabled in 10.0-base (or 5.5?) but incorrectly.
          in 10.0 it's an assert - the feature is surely broken and needs to be disabled unconditionally until fixed.
          but in 5.5/10.0-base it only fails with O_DIRECT on old kernels. which means in other configurations it works. So it should not be disabled in the code, but only turned off by default (until fixed), so that users could enable it where appropriate.

          serg Sergei Golubchik added a comment - now it's disabled in 10.0-base (or 5.5?) but incorrectly. in 10.0 it's an assert - the feature is surely broken and needs to be disabled unconditionally until fixed. but in 5.5/10.0-base it only fails with O_DIRECT on old kernels. which means in other configurations it works. So it should not be disabled in the code, but only turned off by default (until fixed), so that users could enable it where appropriate.
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.3 [ 12900 ]
          Fix Version/s 10.0.2 [ 11900 ]
          wlad Vladislav Vaintroub added a comment -

          Fix was already in 10.0.2, just bug was not closed.

          wlad Vladislav Vaintroub added a comment - Fix was already in 10.0.2, just bug was not closed.
          wlad Vladislav Vaintroub made changes -
          Fix Version/s 10.0.2 [ 11900 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 27003 ] MariaDB v2 [ 44066 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 44066 ] MariaDB v3 [ 63323 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 63323 ] MariaDB v4 [ 132103 ]

          People

            wlad Vladislav Vaintroub
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.