Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
None
Description
This test is (in 10.0.2 at least) unstable. Sometimes SELECT returns incorrect number of pages, namely from before the operation. But if the test is modified to repeat the same SELECT many (e.g. 10) times, then one can see that the number of pages eventually changes to the correct one. There's obviously a race condition here.
One way of fixing the test is to use include/wait_condition.inc and wait for the number of pages to reach the correct value. If the test times out, it would mean a bug.
Attachments
Issue Links
- causes
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Kristian Nielsen [ knielsen ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Fix Version/s | 5.5.31 [ 12700 ] |
Ok, I think I found it.
The test manipulates how purge is done, but the manipulating, debug-only code only works for main thread purge, not for background thread purge.
And while plain innodb has innodb_purge_threads=0 by default, xtradb has it default to 1.
Testing a fix now ...
Fix pushed to 5.5.
The fix is to explicitly set innodb_purge_threads=0 for this test case. Since xtradb defaults to 1, and the debug code used by the test does not work correctly with background purge.
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Priority | Critical [ 2 ] | Major [ 3 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Reopened [ 4 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Issue Type | Task [ 3 ] | Bug [ 1 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Reopened [ 4 ] | Closed [ 6 ] |
The test is still disabled in 10.0. When I enable it — it still fails.
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Workflow | defaullt [ 27000 ] | MariaDB v2 [ 43933 ] |
| Status | Reopened [ 4 ] | Stalled [ 10000 ] |
| Assignee | Kristian Nielsen [ knielsen ] |
| Fix Version/s | 10.0 [ 16000 ] | |
| Fix Version/s | 5.5 [ 15800 ] |
| Fix Version/s | 5.5 [ 15800 ] |
| Assignee | Jan Lindström [ jplindst ] |
| Status | Stalled [ 10000 ] | In Progress [ 3 ] |
revno: 4471
committer: Jan Lindström <jplindst@mariadb.org>
branch nick: 10.0-bugs
timestamp: Mon 2014-11-03 15:47:57 +0200
message:
MDEV-4396: Fix innodb.innodb_bug14676111 test.
| Component/s | Storage Engine - InnoDB [ 10129 ] | |
| Component/s | Storage Engine - XtraDB [ 10135 ] | |
| Fix Version/s | 10.0.15 [ 17300 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Workflow | MariaDB v2 [ 43933 ] | MariaDB v3 [ 63395 ] |
| Link |
This issue causes |
| Assignee | Jan Lindström [ jplindst ] | Elena Stepanova [ elenst ] |
| Assignee | Elena Stepanova [ elenst ] | Jan Lindström [ jplindst ] |
| Workflow | MariaDB v3 [ 63395 ] | MariaDB v4 [ 146607 ] |
I do not understand the suggested fix. All the failures I see in the buildbot test failure database start with this:
+Timeout in wait_condition.inc for SELECT VARIABLE_VALUE < 1 FROM INFORMATION_SCHEMA.GLOBAL_STATUS
+WHERE VARIABLE_NAME = 'INNODB_PURGE_TRX_ID_AGE'
+Id User Host db Command Time State Info Progress
+1 root localhost test Query 0 NULL show full processlist 0.000
So there is already a timeout in a wait_condition, I do not understand how adding another condition can fix this?