Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4351

LevelDB: Build system must be able to find leveldb library

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      Currently, LevelDB Storage Engine source code has paths to leveldb hardcoded in storage/leveldb/CMakeLists.txt.

      This task is about fixing this. The fix should work like a similar fix for Cassandra Storage Engine: the build system should
      1. check some environment variable
      2. Search for leveldb include/library files in likely locations (like /opt, /usr/local, etc)

      Differences from Cassandra SE's case:

      • the tree is based on MySQL-5.6, not on MariaDB.
      • the storage engine is not built as a shared module.

      The code is at: https://code.launchpad.net/~maria-captains/maria/mysql-5.6-leveldb

      (original complaint is: MDEV-4154. Please close it when this task is closed)

      Attachments

        Issue Links

          Activity

            psergei Sergei Petrunia created issue -
            psergei Sergei Petrunia made changes -
            Field Original Value New Value
            psergei Sergei Petrunia made changes -
            psergei Sergei Petrunia made changes -
            Description Currently, LevelDB Storage Engine source code has paths to leveldb hardcoded in storage/leveldb/CMakeLists.txt.

            This task is about fixing this. The fix should work like a similar fix for Cassandra Storage Engine: the build system should
            1. check some environment variable
            2. Search for leveldb include/library files in likely locations (like /opt, /usr/local, etc)

            Differences from Cassandra SE's case:
            - the tree is based on MySQL-5.6, not on MariaDB.
            - the storage engine is not built as a shared module.

            The code is at: https://code.launchpad.net/~maria-captains/maria/mysql-5.6-leveldb

            This causes complaints like MDEV-4154
            Currently, LevelDB Storage Engine source code has paths to leveldb hardcoded in storage/leveldb/CMakeLists.txt.

            This task is about fixing this. The fix should work like a similar fix for Cassandra Storage Engine: the build system should
            1. check some environment variable
            2. Search for leveldb include/library files in likely locations (like /opt, /usr/local, etc)

            Differences from Cassandra SE's case:
            - the tree is based on MySQL-5.6, not on MariaDB.
            - the storage engine is not built as a shared module.

            The code is at: https://code.launchpad.net/~maria-captains/maria/mysql-5.6-leveldb

            (original complaint is: MDEV-4154. Please close it when this task is closed)
            psergei Sergei Petrunia made changes -
            psergei Sergei Petrunia made changes -
            psergei Sergei Petrunia made changes -
            Assignee Jani Tolonen [ jani ]
            jani Jani Tolonen made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jani Jani Tolonen made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            jani Jani Tolonen added a comment -

            Fixed in mysql-5.6-leveldb. Added optional environment variables LEVELDB_INCLUDE= and LEVELDB_LIBRARIES= for finding includes and libraries if system cannot autodetect them.

            jani Jani Tolonen added a comment - Fixed in mysql-5.6-leveldb. Added optional environment variables LEVELDB_INCLUDE= and LEVELDB_LIBRARIES= for finding includes and libraries if system cannot autodetect them.
            jani Jani Tolonen made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 26839 ] MariaDB v2 [ 46538 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 46538 ] MariaDB v3 [ 67244 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 67244 ] MariaDB v4 [ 132096 ]

            People

              jani Jani Tolonen
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.