Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-417

atomics not used in MariaDB 5.5 on Windows, because of typo in include/atomic/nolock.h

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      There is a typo in include/atomic/nolock.h, which prevents atomics to be used on Windows. The correct builtin macro that to detect Microsoft compiler detection is _MSC_VERSION, not _MSV_VERSION

      The bug was introduced by revid:mikael@mysql.com-20091219074637-x0ekq50wn201nfod

      Attachments

        Activity

          wlad Vladislav Vaintroub created issue -
          wlad Vladislav Vaintroub made changes -
          Field Original Value New Value
          Summary atomics broken in MariaDB 5.5 atomics not used in MariaDB 5.5 on Windows, because of typo in include/atomic/nolock.h
          wlad Vladislav Vaintroub made changes -
          Assignee Vladislav Vaintroub [ wlad ]
          wlad Vladislav Vaintroub made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 13602 ] MariaDB v2 [ 44943 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 44943 ] MariaDB v3 [ 65176 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 65176 ] MariaDB v4 [ 131955 ]

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.