Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4108

Compilation warnings with RelWithDebInfo only present in the Galera tree

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 5.5.28a-galera
    • 5.5.34-galera
    • None
    • Ubuntu 11.10 x86_64, gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1, cmake version 2.8.5

    Description

      Please check if any of these can/should be fixed.

      client/mysqldump.c: In function 'print_xml_row':
      		 
      client/mysqldump.c:1917:11: warning: variable 'body_found' set but not used [-Wunused-but-set-variable]
      		 
       
      		 
      sql/handler.cc: In function 'int ha_commit_trans(THD*, bool)':
      		 
      sql/handler.cc:1278:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
      		 
       
      		 
      sql/sql_table.cc: In function 'bool mysql_alter_table(THD*, char*, char*, HA_CREATE_INFO*, TABLE_LIST*, Alter_info*, uint, ORDER*, bool, bool)':
      		 
      sql/sql_table.cc:6251:10: warning: unused variable 'do_log_write' [-Wunused-variable]
      		 

      revision-id: sergii@pisem.net-20121220113437-x6wi7x1taracdrdn
      		 
      revno: 3365
      		 
      branch-nick: maria-5.5-galera

      Built as
      cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo && make

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova created issue -
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          elenst Elena Stepanova made changes -
          Summary Galera: Compilation warnings with RelWithDebInfo only present in the Galera tree Compilation warnings with RelWithDebInfo only present in the Galera tree
          elenst Elena Stepanova made changes -
          Description Please check if any of these can/should be fixed.

          {noformat}
          client/mysqldump.c: In function 'print_xml_row':
          client/mysqldump.c:1917:11: warning: variable 'body_found' set but not used [-Wunused-but-set-variable]

          sql/handler.cc: In function 'int ha_commit_trans(THD*, bool)':
          sql/handler.cc:1278:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

          sql/sql_table.cc: In function 'bool mysql_alter_table(THD*, char*, char*, HA_CREATE_INFO*, TABLE_LIST*, Alter_info*, uint, ORDER*, bool, bool)':
          sql/sql_table.cc:6251:10: warning: unused variable 'do_log_write' [-Wunused-variable]
          {noformat}

          {noformat}
          revision-id: sergii@pisem.net-20121220113437-x6wi7x1taracdrdn
          revno: 3365
          branch-nick: maria-5.5-galera-clean
          {noformat}

          Built as
          {{cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo && make}}

          		 Please check if any of these can/should be fixed.

          {noformat}
          client/mysqldump.c: In function 'print_xml_row':
          client/mysqldump.c:1917:11: warning: variable 'body_found' set but not used [-Wunused-but-set-variable]

          sql/handler.cc: In function 'int ha_commit_trans(THD*, bool)':
          sql/handler.cc:1278:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

          sql/sql_table.cc: In function 'bool mysql_alter_table(THD*, char*, char*, HA_CREATE_INFO*, TABLE_LIST*, Alter_info*, uint, ORDER*, bool, bool)':
          sql/sql_table.cc:6251:10: warning: unused variable 'do_log_write' [-Wunused-variable]
          {noformat}

          {noformat}
          revision-id: sergii@pisem.net-20121220113437-x6wi7x1taracdrdn
          revno: 3365
          branch-nick: maria-5.5-galera
          {noformat}

          Built as
          {{cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo && make}}
          serg Sergei Golubchik made changes -
          Fix Version/s 5.5.30-galera [ 12800 ]
          Fix Version/s 5.5.29-galera [ 12300 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Fix Version/s 5.5.xx-galera [ 13203 ]
          Fix Version/s 5.5.31-galera [ 12800 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Fix Version/s 5.5.33-galera [ 13600 ]
          Fix Version/s 5.5.32-galera [ 13203 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 5.5.34-galera [ 13900 ]
          Fix Version/s 5.5.33a-galera [ 13600 ]
          nirbhay_c Nirbhay Choubey (Inactive) made changes -
          Assignee Seppo Jaakola [ seppo ] Nirbhay Choubey [ nirbhay_c ]
          nirbhay_c Nirbhay Choubey (Inactive) made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          nirbhay_c Nirbhay Choubey (Inactive) added a comment -

          Fix for this bug has been pushed to maria-5.5-galera.

          nirbhay_c Nirbhay Choubey (Inactive) added a comment - Fix for this bug has been pushed to maria-5.5-galera.
          nirbhay_c Nirbhay Choubey (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow defaullt [ 26047 ] MariaDB v2 [ 44503 ]
          ratzpo Rasmus Johansson (Inactive) made changes -
          Workflow MariaDB v2 [ 44503 ] MariaDB v3 [ 63858 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 63858 ] MariaDB v4 [ 146389 ]

          People

            nirbhay_c Nirbhay Choubey (Inactive)
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.