Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4048

check that plugins_foreach isn't called under thd->LOCK_ha_data

    XMLWordPrintable

Details

    • Task
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Incomplete
    • 10.0.2
    • None
    • None

    Description

      check that plugins_foreach isn't called under thd->LOCK_ha_data.

      either with mysql_mutex_assert_not_owner()
      or with mysql_mutex_record_order()

      note this change:

      === modified file 'sql/sql_class.cc'
      --- sql/sql_class.cc	2012-12-20 23:12:37 +0000
      +++ sql/sql_class.cc	2013-01-10 22:22:14 +0000
      @@ -736,8 +736,9 @@
           str.append(proc_info);
         }
       
      -  mysql_mutex_lock(&thd->LOCK_thd_data);
      -
      +  /* Don't wait if LOCK_thd_data is used as this could cause a deadlock */
      +  if (!mysql_mutex_trylock(&thd->LOCK_thd_data))
      +  {
         if (thd->query())
         {
           if (max_query_len < 1)

      Attachments

        Activity

          People

            serg Sergei Golubchik
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.