Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4040

Replace deprecated SET OPTION syntax in mysqldump

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5.28a, 5.3.11, 5.2.13, 5.1.66
    • 5.5.29, 5.2.14, 5.3.12
    • None

    Description

      psergey filed the upstream bug as http://bugs.mysql.com/bug.php?id=67507 over 2 months ago, but there has been no progress ever since, so maybe it's time to start doing something on our side, since 5.5.29 still has it and incompatible clients keep spreading.

      According to MySQL manual, the syntax SET OPTION was deprecated (even although it doesn't seem to produce any warnings in 5.5), and now in 5.6 it's removed. However, even current versions of mysqldump 5.1-5.5 keep using it, which makes mysqldump < 5.6 incompatible with server 5.6 / 10.0.

      I think we should at least replace SET OPTION with SET in mysqldump 5.3/5.5 (or maybe even 5.1..5.5) to stop producing potentially incompatible versions.

      Additionally, please consider if we should prolong life of SET OPTION syntax in 10.x in order to let patched clients a chance to replace the old ones. (This part is not indicated in Affected/Fixed versions as it's just a suggestion for future).

      Attachments

        Issue Links

          Activity

            elenst Elena Stepanova created issue -
            elenst Elena Stepanova made changes -
            Field Original Value New Value
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            Description _Sergey Petrunia filed the upstream bug as http://bugs.mysql.com/bug.php?id=67507 over 2 months ago, but there has been no progress ever since, so maybe it's time to start doing something on our side, since 5.5.29 still has it and incompatible clients keep spreading._

            According to MySQL manual, the syntax {{SET OPTION}} was deprecated (even although it doesn't seem to produce any warnings in 5.5), and now in 5.6 it's removed. However, even current versions of mysqldump 5.1-5.5 keep using it, which makes mysqldump < 5.6 incompatible with server 5.6 / 10.0.

            I think we should at least replace {{SET OPTION}} with {{SET}} in mysqldump 5.3/5.5 (or maybe even 5.1..5.5) to stop producing potentially incompatible versions.

            Additionally, please consider if we should prolong life of {{SET OPTION}} syntax in 10.x in order to let patched clients a chance to replace the old ones. (This part is not indicated in Affected/Fixed versions as it's just a suggestion for future).
            _[~psergey] filed the upstream bug as http://bugs.mysql.com/bug.php?id=67507 over 2 months ago, but there has been no progress ever since, so maybe it's time to start doing something on our side, since 5.5.29 still has it and incompatible clients keep spreading._

            According to MySQL manual, the syntax {{SET OPTION}} was deprecated (even although it doesn't seem to produce any warnings in 5.5), and now in 5.6 it's removed. However, even current versions of mysqldump 5.1-5.5 keep using it, which makes mysqldump < 5.6 incompatible with server 5.6 / 10.0.

            I think we should at least replace {{SET OPTION}} with {{SET}} in mysqldump 5.3/5.5 (or maybe even 5.1..5.5) to stop producing potentially incompatible versions.

            Additionally, please consider if we should prolong life of {{SET OPTION}} syntax in 10.x in order to let patched clients a chance to replace the old ones. (This part is not indicated in Affected/Fixed versions as it's just a suggestion for future).
            serg Sergei Golubchik made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5.29 [ 12102 ]
            Fix Version/s 5.2.14 [ 12101 ]
            Fix Version/s 5.5.30 [ 11800 ]
            serg Sergei Golubchik made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow defaullt [ 25912 ] MariaDB v2 [ 46447 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 46447 ] MariaDB v3 [ 67151 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 67151 ] MariaDB v4 [ 146335 ]

            People

              serg Sergei Golubchik
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.