Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-40210

Redundant CAS in async_flush_lsn::try_clear_if_at_most()

    XMLWordPrintable

Details

    Description

      MDEV-39600 added an helper function to clear buf_flush_async_lsn with an atomic CAS to preserve concurrent bumps.
      Turns out that indeed there is no need to CAS with 0 if the snapshot is already 0, therefore for the common case (no-async-flushing), the CAS can be avoided.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-39600 buf_flush_ahead() for async flushing causes contention on buf_pool.flush_list_mutex

          • Major - Major loss of function.
          • Closed
          relates to

          PERF-475 Loading...

          Activity

            People

              alessandro.vetere Alessandro Vetere
              alessandro.vetere Alessandro Vetere
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0.5d
                  0.5d
                  Remaining:
                  Remaining Estimate - 0d
                  0d
                  Logged:
                  Time Spent - 0.5h Time Not Required
                  0.5h

                  Git Integration

                    Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.