Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-40073

Merge MySQL support in mariadb-dump into 13.0

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Duplicate
    • 13.0
    • N/A
    • Scripts & Clients
    • None
    • Related to install and upgrade
    • Q3/2026 Replic. Maintenance

    Description

      When I merged 12.3 to 13.0, I was not able to fully merge the following two commits:

      commit 666ff1db3669a02025ae33d2cd1dfd263095c18d
      Author: Monty <monty@mariadb.org>
      Date:   Fri May 15 16:39:35 2026 +0300
       
          MDEV-39519 Change mariadb-dump to use SHOW REPLICA STATUS instead of SHOW SL
      AVE STATUS
      

      commit 21c940d5996d9a72324642a92b8bd20f71de5590
      Author: ParadoxV5 <paradox.ver5@gmail.com>
      Date:   Thu Dec 4 21:22:20 2025 -0700
       
          MDEV-37146 mariadb-dump: Replace SHOW SLAVE STATUS usage with information_sc
      hema.SLAVE_STATUS
      

      The first patch adds code to make mariadb-dump --master-data and mariadb-dump --dump-slave work with MySQL servers, where SHOW REPLICA STATUS needs to be used instead of SHOW MASTER STATUS, etc.
      The second patch adds code different form the support for pre-mariadb 10.0 servers for --dump-slave, and thus for MySQL servers. (EDITED by ParadoxV5)

      Thus when merging, I had to omit the conflicting code, mainly this part:

      +static int show_slave_status(MYSQL *mysql_con, MYSQL_RES **res)
      +{
      +  return (mysql_query_with_retry(mysql_con, res,
      +                                 (multi_source ?
      +                                  "SHOW ALL REPLICAS STATUS" :
      +                                  "SHOW REPLICA STATUS"),
      +                                 (multi_source ?
      +                                  "SHOW ALL SLAVES STATUS" :
      +                                  "SHOW SLAVE STATUS")));
      +}
       
      -  if (mysql_query_with_error_report(mysql_con, &slave_status_res,
      -                                    multi_source ?
      -                                    "SHOW ALL SLAVES STATUS" :
      -                                    "SHOW SLAVE STATUS"))
      +  if (show_slave_status(mysql_con, &slave_status_res))
      

      Monty asked me to file this jira issue for implementing in 13.0 the lost support for older servers in mariadb-dump (mainly for MySQL support).

      Attachments

        Issue Links

          Activity

            People

              ParadoxV5 Jimmy Hú
              knielsen Kristian Nielsen
              Jimmy Hú Jimmy Hú
              Brandon Nesterenko Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.