Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-3990

engines/* and storage_engine tests and result files went out of sync with current MariaDB code

Details

    • Task
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.0.2, 5.5.29
    • None
    • None

    Description

      storage_engine tests and upstream engines/* suites went out of sync with current MariaDB code. Reasons:

      • as of 5.5.27, YEAR(2) is deprecated, hence the new warning;
      • MDEV-533 - different error code/message on out-of-range auto-increment;
      • INSERT IGNORE now produces a warning if a duplicate key was encountered (change pushed along with MDEV-533).

      Result files need to be updated. For MDEV-533, also test files which expect a different error code need to be modified.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-3942 FROM_DAYS(<timestamp column>) returns different result in MariaDB comparing to MySQL: NULL vs 0000-00-00

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            elenst Elena Stepanova added a comment -

            Hi Sergei,

            Here is the 10.0 part (on top of the previous change):
            http://bazaar.launchpad.net/~elenst/maria/10.0-base-mdev3990/revision/3468

            I listed sources of the differences, as much as I could identify them, in the commit comment.

            elenst Elena Stepanova added a comment - Hi Sergei, Here is the 10.0 part (on top of the previous change): http://bazaar.launchpad.net/~elenst/maria/10.0-base-mdev3990/revision/3468 I listed sources of the differences, as much as I could identify them, in the commit comment.
            serg Sergei Golubchik added a comment - - edited

            Everything, but the insert_time.result is certainly ok.
            changes in the insert_time.result look plausible too, but I didn't track every 00:00:00 change back to its origin, incorrectly formatted time.

            serg Sergei Golubchik added a comment - - edited Everything, but the insert_time.result is certainly ok. changes in the insert_time.result look plausible too, but I didn't track every 00:00:00 change back to its origin, incorrectly formatted time.
            elenst Elena Stepanova added a comment - - edited

            What I did was take this test:

            create table t1 (c1 time);
            insert into t1 values ('00:00:00');
            select * from t1 where c1 >='12colon34colon56';
            c1
            00:00:00
            Warnings:
            Warning 1292 Truncated incorrect time value: '12colon34colon56'

            And ran it before and after MDEV-457 fix. Before it was returning the value, after it wasn't – so I figured it's related to that change. MySQL doesn't return a value either, so at least it's consistent.

            My understanding is this:
            '12colon34colon56' is truncated to '12' and considered to be '00:00:12';
            so, everything less than that (up to and including '00:00:11' in that test) is filtered out, and the rest is included in the result set.

            elenst Elena Stepanova added a comment - - edited What I did was take this test: create table t1 (c1 time); insert into t1 values ('00:00:00'); select * from t1 where c1 >='12colon34colon56'; c1 00:00:00 Warnings: Warning 1292 Truncated incorrect time value: '12colon34colon56' And ran it before and after MDEV-457 fix. Before it was returning the value, after it wasn't – so I figured it's related to that change. MySQL doesn't return a value either, so at least it's consistent. My understanding is this: '12colon34colon56' is truncated to '12' and considered to be '00:00:12'; so, everything less than that (up to and including '00:00:11' in that test) is filtered out, and the rest is included in the result set.
            serg Sergei Golubchik added a comment -

            ok to push in 10.0-base

            serg Sergei Golubchik added a comment - ok to push in 10.0-base
            elenst Elena Stepanova added a comment -

            pushed into 10.0-base

            elenst Elena Stepanova added a comment - pushed into 10.0-base

            People

              elenst Elena Stepanova
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.