Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-37843

Remove InnoDB "optimizations" for debug_no_sync

    XMLWordPrintable

Details

    • Related to performance

    Description

      Remove InnoDB "optimizations" for debug_no_sync

      The debug_no_sync variable is intended as a debug-only feature. Its sole purpose is to replace fsync/FlushFileBuffers with a no-op. No higher-level logic should depend on it.

      Currently, InnoDB reads this variable in multiple higher-level, concurrency-relevant places. This introduces unnecessary memory reads and extra logical instructions, effectively mimicking the behavior of innodb_flush_log_at_trx_commit=0, which users can already set explicitly.

      The only proper location in Innodb to read this variable would be in os_file_flush_func().

      Attachments

        Issue Links

          is caused by

          New Feature - A new feature of the product, which has yet to be developed. MDEV-30136 Map innodb_flush_method to new settable Booleans innodb_{log,data}_file_{buffering,write_through}

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30054 debug-no-sync doesnt fully disable sync calls

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              wlad Vladislav Vaintroub
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.