Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36253

Redundant check in wf_incremental_process()

Details

    Description

      As a part of commit 1c55b845e0fe337e647ba230288ed13e966cb7c7, mariabackup
      does have redundant check to find out whether the TRX_SYS page has been modified.
      Remove the redundant check.

                      /* Check whether TRX_SYS page has been changed */
                      if (mach_read_from_4(page + FIL_PAGE_SPACE_ID)
                                      == TRX_SYS_SPACE
                          && mach_read_from_4(page + FIL_PAGE_OFFSET)
                                      == TRX_SYS_PAGE_NO) {
                              msg(cursor->thread_n,
                                  "--incremental backup is impossible if "
                                  "the server had been restarted with "
                                  "different innodb_undo_tablespaces.");
                              return false;
                      }
       
                      /* Check whether TRX_SYS page has been changed */
                      if (mach_read_from_4(page + FIL_PAGE_SPACE_ID)
                                      == TRX_SYS_SPACE
                          && mach_read_from_4(page + FIL_PAGE_OFFSET)
                                      == TRX_SYS_PAGE_NO) {
                              msg(cursor->thread_n,
                                  "--incremental backup is impossible if "
                                  "the server had been restarted with "
                                  "different innodb_undo_tablespaces.");
                              return false;
                      }
      

      Attachments

        Issue Links

          Activity

            thiru Thirunarayanan Balathandayuthapani created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            Labels regression
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2025-03-10 06:49:30.0 2025-03-10 06:49:30.228
            marko Marko Mäkelä made changes -
            Fix Version/s 10.11.12 [ 29998 ]
            Fix Version/s 11.4.6 [ 29999 ]
            Fix Version/s 11.8.2 [ 30001 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.4 [ 29301 ]
            Fix Version/s 11.8 [ 29921 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]

            People

              thiru Thirunarayanan Balathandayuthapani
              thiru Thirunarayanan Balathandayuthapani
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.