Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36245

Long server_audit_file_path causes buffer overflow

Details

    Description

      Currently, the length of the server_audit_file_path system variable value is
      not checked. This can cause a buffer overflow if given a long file path
      specifying a directory as a memcpy() is performed to copy the entire file path into a
      fixed size buffer, char alt_path_buffer[FN_REFLEN+1+DEFAULT_FILENAME_LEN];

      Pull request: https://github.com/MariaDB/server/pull/3874

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          holyfoot Alexey Botchkov added a comment -

          The patch is basically ok.
          Test should be added and one more explanation.

          holyfoot Alexey Botchkov added a comment - The patch is basically ok. Test should be added and one more explanation.
          svoj Sergey Vojtovich added a comment -

          Back to "In Review" as contributor didn't respond and we aim to implement requested changes ourselves.

          svoj Sergey Vojtovich added a comment - Back to "In Review" as contributor didn't respond and we aim to implement requested changes ourselves.

          People

            holyfoot Alexey Botchkov
            svoj Sergey Vojtovich
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.