Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36245

Long server_audit_file_path causes buffer overflow

Details

    Description

      Currently, the length of the server_audit_file_path system variable value is
      not checked. This can cause a buffer overflow if given a long file path
      specifying a directory as a memcpy() is performed to copy the entire file path into a
      fixed size buffer, char alt_path_buffer[FN_REFLEN+1+DEFAULT_FILENAME_LEN];

      Pull request: https://github.com/MariaDB/server/pull/3874

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          svoj Sergey Vojtovich created issue -
          svoj Sergey Vojtovich made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          svoj Sergey Vojtovich made changes -
          Status In Progress [ 3 ] In Testing [ 10301 ]
          svoj Sergey Vojtovich made changes -
          Status In Testing [ 10301 ] Stalled [ 10000 ]
          svoj Sergey Vojtovich made changes -
          Status Stalled [ 10000 ] In Testing [ 10301 ]
          svoj Sergey Vojtovich made changes -
          Status In Testing [ 10301 ] Stalled [ 10000 ]
          svoj Sergey Vojtovich made changes -
          Assignee Sergey Vojtovich [ svoj ] Alexey Botchkov [ holyfoot ]
          Status Stalled [ 10000 ] In Review [ 10002 ]
          serg Sergei Golubchik made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          serg Sergei Golubchik made changes -
          Affects Version/s 10.5 [ 23123 ]
          Affects Version/s 10.6 [ 24028 ]
          Affects Version/s 10.11 [ 27614 ]
          Affects Version/s 11.4 [ 29301 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.4 [ 29301 ]
          Fix Version/s 11.8 [ 29921 ]
          holyfoot Alexey Botchkov added a comment -

          The patch is basically ok.
          Test should be added and one more explanation.

          holyfoot Alexey Botchkov added a comment - The patch is basically ok. Test should be added and one more explanation.
          holyfoot Alexey Botchkov made changes -
          Status In Review [ 10002 ] Stalled [ 10000 ]
          svoj Sergey Vojtovich made changes -
          Assignee Alexey Botchkov [ holyfoot ] Sergey Vojtovich [ svoj ]
          svoj Sergey Vojtovich added a comment -

          Back to "In Review" as contributor didn't respond and we aim to implement requested changes ourselves.

          svoj Sergey Vojtovich added a comment - Back to "In Review" as contributor didn't respond and we aim to implement requested changes ourselves.
          svoj Sergey Vojtovich made changes -
          Assignee Sergey Vojtovich [ svoj ] Alexey Botchkov [ holyfoot ]
          Status Stalled [ 10000 ] In Review [ 10002 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.5.29 [ 29996 ]
          Fix Version/s 10.6.22 [ 29997 ]
          Fix Version/s 10.11.12 [ 29998 ]
          Fix Version/s 11.4.6 [ 29999 ]
          Fix Version/s 11.8.2 [ 30001 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.4 [ 29301 ]
          Fix Version/s 11.8 [ 29921 ]
          Resolution Fixed [ 1 ]
          Status In Review [ 10002 ] Closed [ 6 ]

          People

            holyfoot Alexey Botchkov
            svoj Sergey Vojtovich
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.