MDEV-34996 was incomplete it its testing of -stdlib=libc++ as this required -fsanitize=memory
The MY_CHECK_AND_SET_COMPILER_FLAG("-fsanitize=memory prior to MY_CHECK_CXX_COMPILER_FLAG("-stdlib=libc++") doesn't set the CMAKE_REQUIRED_FLAGS so results in:
/source/CMakeLists.txt(249): MY_CHECK_CXX_COMPILER_FLAG(-stdlib=libc++ )
|
/source/cmake/check_compiler_flag.cmake(28): STRING(REGEX REPLACE [-,= +] _ result have_CXX_-stdlib=libc++ )
|
/source/cmake/check_compiler_flag.cmake(29): SET(SAVE_CMAKE_REQUIRED_FLAGS )
|
/source/cmake/check_compiler_flag.cmake(30): SET(CMAKE_REQUIRED_FLAGS -stdlib=libc++ )
|
/source/cmake/check_compiler_flag.cmake(31): CHECK_CXX_SOURCE_COMPILES(int main(void) { return 0; } have_CXX__stdlib_libc__ FAIL_REGEX;argument unused during compilation;FAIL_REGEX;unsupported .*option;FAIL_REGEX;unknown .*option;FAIL_REGEX;unrecognized .*option;FAIL_REGEX;ignoring unknown option;FAIL_REGEX;warning:.*ignored;FAIL_REGEX;warning:.*is valid for.*but not for;FAIL_REGEX;warning:.*redefined;FAIL_REGEX;[Ww]arning: [Oo]ption )
|
-- Performing Test have_CXX__stdlib_libc__
|
-- Performing Test have_CXX__stdlib_libc__ - Failed
|
/source/cmake/check_compiler_flag.cmake(33): SET(CMAKE_REQUIRED_FLAGS )
|
/source/CMakeLists.txt(250): IF(NOT have_CXX__stdlib_libc__ )
|
/source/CMakeLists.txt(251): MESSAGE(FATAL_ERROR C++ Compiler requires support for -stdlib=libc++ )
|
CMake Error at CMakeLists.txt:251 (MESSAGE):
|
C++ Compiler requires support for -stdlib=libc++
|
|
|
-- Configuring incomplete, errors occurred!
|
See also "/build/CMakeFiles/CMakeOutput.log".
|
See also "/build/CMakeFiles/CMakeError.log".
|
buildbot@2f11790aa1e1:/build$ rm -rf .ninja_*
|
buildbot@2f11790aa1e1:/build$ tail -n 30 /build/CMakeFiles/CMakeError.log
|
Change Dir: /build/CMakeFiles/CMakeScratch/TryCompile-RfQ4we
|
|
Run Build Command(s):/usr/bin/ninja cmTC_2cfad && [1/2] Building CXX object CMakeFiles/cmTC_2cfad.dir/src.cxx.o
|
[2/2] Linking CXX executable cmTC_2cfad
|
FAILED: cmTC_2cfad
|
: && /usr/bin/clang++ -stdlib=libc++ -L/msan-libs -Wl,-rpath=/msan-libs CMakeFiles/cmTC_2cfad.dir/src.cxx.o -o cmTC_2cfad && :
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_memset'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_retval_origin_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_unpoison'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_param_origin_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_memcpy'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_retval_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_va_arg_overflow_size_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_va_arg_origin_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__sanitizer_dtor_callback_fields'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_memmove'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_chain_origin'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__sanitizer_dtor_callback_vptr'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_va_arg_tls'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_warning_with_origin_noreturn'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_set_alloca_origin_with_descr'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_init'
|
/usr/bin/ld: /msan-libs/libc++.so.1: undefined reference to `__msan_param_tls'
|
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
|
ninja: build stopped: subcommand failed.
|
- is caused by
-
MDEV-34996
Buildbot MSAN options in buildbot rather than server
-
-
Closed
{"report":{"fcp":1642.1000000238419,"ttfb":628.1000000238419,"pageVisibility":"visible","entityId":132981,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"63dad4e6-e896-4af0-8cd0-acf7eddc03a2","navigationType":0,"readyForUser":1720.6999999284744,"redirectCount":0,"resourceLoadedEnd":2458.2999999523163,"resourceLoadedStart":651.5,"resourceTiming":[{"duration":515.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":651.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":651.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1167.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":515.8999999761581,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":651.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":651.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1167.6999999284744,"responseStart":0,"secureConnectionStart":0},{"duration":524.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":652,"connectEnd":652,"connectStart":652,"domainLookupEnd":652,"domainLookupStart":652,"fetchStart":652,"redirectEnd":0,"redirectStart":0,"requestStart":652,"responseEnd":1176.3999999761581,"responseStart":1176.3999999761581,"secureConnectionStart":652},{"duration":562.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":652.1999999284744,"connectEnd":652.1999999284744,"connectStart":652.1999999284744,"domainLookupEnd":652.1999999284744,"domainLookupStart":652.1999999284744,"fetchStart":652.1999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":652.1999999284744,"responseEnd":1214.3999999761581,"responseStart":1214.3999999761581,"secureConnectionStart":652.1999999284744},{"duration":566.1000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":652.3999999761581,"connectEnd":652.3999999761581,"connectStart":652.3999999761581,"domainLookupEnd":652.3999999761581,"domainLookupStart":652.3999999761581,"fetchStart":652.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":652.3999999761581,"responseEnd":1218.5,"responseStart":1218.5,"secureConnectionStart":652.3999999761581},{"duration":565.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":653.2999999523163,"connectEnd":653.2999999523163,"connectStart":653.2999999523163,"domainLookupEnd":653.2999999523163,"domainLookupStart":653.2999999523163,"fetchStart":653.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":653.2999999523163,"responseEnd":1218.8999999761581,"responseStart":1218.8999999761581,"secureConnectionStart":653.2999999523163},{"duration":565.6999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":653.6000000238419,"connectEnd":653.6000000238419,"connectStart":653.6000000238419,"domainLookupEnd":653.6000000238419,"domainLookupStart":653.6000000238419,"fetchStart":653.6000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":653.6000000238419,"responseEnd":1219.2999999523163,"responseStart":1219.2999999523163,"secureConnectionStart":653.6000000238419},{"duration":667.9000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":653.6999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":653.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1321.6000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":566,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":653.7999999523163,"connectEnd":653.7999999523163,"connectStart":653.7999999523163,"domainLookupEnd":653.7999999523163,"domainLookupStart":653.7999999523163,"fetchStart":653.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":653.7999999523163,"responseEnd":1219.7999999523163,"responseStart":1219.7999999523163,"secureConnectionStart":653.7999999523163},{"duration":667.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":654,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":654,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1321.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":566.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":654.1000000238419,"connectEnd":654.1000000238419,"connectStart":654.1000000238419,"domainLookupEnd":654.1000000238419,"domainLookupStart":654.1000000238419,"fetchStart":654.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":654.1000000238419,"responseEnd":1220.3999999761581,"responseStart":1220.3999999761581,"secureConnectionStart":654.1000000238419},{"duration":999.6000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":655,"connectEnd":655,"connectStart":655,"domainLookupEnd":655,"domainLookupStart":655,"fetchStart":655,"redirectEnd":0,"redirectStart":0,"requestStart":655,"responseEnd":1654.6000000238419,"responseStart":1654.5,"secureConnectionStart":655},{"duration":1803.1999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":655.1000000238419,"connectEnd":655.1000000238419,"connectStart":655.1000000238419,"domainLookupEnd":655.1000000238419,"domainLookupStart":655.1000000238419,"fetchStart":655.1000000238419,"redirectEnd":0,"redirectStart":0,"requestStart":655.1000000238419,"responseEnd":2458.2999999523163,"responseStart":2458.2999999523163,"secureConnectionStart":655.1000000238419},{"duration":345.7999999523163,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1349,"connectEnd":1349,"connectStart":1349,"domainLookupEnd":1349,"domainLookupStart":1349,"fetchStart":1349,"redirectEnd":0,"redirectStart":0,"requestStart":1349,"responseEnd":1694.7999999523163,"responseStart":1694.7999999523163,"secureConnectionStart":1349},{"duration":847.7000000476837,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1635.6999999284744,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1635.6999999284744,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2483.399999976158,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":466,"responseStart":628,"responseEnd":631,"domLoading":648,"domInteractive":2489,"domContentLoadedEventStart":2489,"domContentLoadedEventEnd":2534,"domComplete":3468,"loadEventStart":3468,"loadEventEnd":3468,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2462.7999999523163},{"name":"bigPipe.sidebar-id.end","time":2463.6999999284744},{"name":"bigPipe.activity-panel-pipe-id.start","time":2463.899999976158},{"name":"bigPipe.activity-panel-pipe-id.end","time":2466},{"name":"activityTabFullyLoaded","time":2550.399999976158}],"measures":[],"correlationId":"7f86bffd4fe300","effectiveType":"4g","downlink":9.2,"rtt":0,"serverDuration":102,"dbReadsTimeInMs":13,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
adjusted per wlad's review - without CMP0066. compliler/linker flag changes where needed and adjusted commit message to be a bit more explicit why.
I'm hoping justification for 10.6 is sufficient. I don't currently have push access there so if acceptable can you hit the merge on the PR wlad?
If 10.5 is/was acceptable I'd take that too and simplify some upcoming msan BB changes with one less cmake argument.