Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-36082

Race condition between log_t::resize_start() and log_t::resize_abort()

Details

    Description

      mleich produced an rr replay trace where SET GLOBAL innodb_log_file_size leads to a debug assertion failure:

      10.11-MDEV-29445

      		 
      mariadbd: /data/Server/10.11-MDEV-29445/storage/innobase/log/log0log.cc:972: lsn_t log_t::write_buf() [with resizing_and_latch resizing = log_t::RESIZING; lsn_t = long unsigned int]: Assertion `resizing == RETAIN_LATCH || (resizing == RESIZING) == (resize_in_progress() > 1)' failed.

      We have log_sys.resize_lsn = 1, which means that log resizing is only about to start, and hence log_t::writer_update() had better not yet have assigned log_sys.writer=log_writer_resizing.

      In this trace, one log resizing is about to start, and another is being interrupted:

      SET GLOBAL innodb_log_file_size = 104857600 + 52428800 /* E_R Thread2 QNO 466 CON_ID 195 */ ;
      		 
      SET GLOBAL innodb_log_file_size = 104857600 /* E_R Thread2 QNO 454 CON_ID 192 */ ;

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-27812 Allow innodb_log_file_size to change without server restart

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35810 Missing error handling in log resizing around ib_logfile101

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Marko Mäkelä made transition -
            Open In Progress
            		1h 32m 1
            Marko Mäkelä made transition -
            In Progress In Review
            		7s 1
            Marko Mäkelä made transition -
            Stalled In Review
            		6h 11m 1
            Debarun Banerjee made transition -
            In Review Stalled
            		3d 18h 15m 2
            Marko Mäkelä made transition -
            Stalled Closed
            		1d 19h 50m 1

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.