Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35785

innodb_log_file_mmap is not defined on 32-bit systems

Details

    Description

      otto pointed out that the configuration parameter innodb_log_file_mmap is not available on 32-bit target platforms, for no apparent reason.

      When fixing MDEV-34062 I had thought that including two ib_logfile0 parsers would unnecessarily increase the size of the code. Technically, we can in fact memory-map the InnoDB write-ahead log ib_logfile0 also on 32-bit systems, provided that the size is small enough so that the virtual address space will not be exhausted.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34062 mariadb-backup --backup is extremely slow at copying ib_logfile0

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            debarun Debarun Banerjee added a comment -

            Good that we are getting rid of some conditional paths HAVE_INNODB_MMAP. Please check the backup source file too. I wonder if some backup test should have caught it,

            debarun Debarun Banerjee added a comment - Good that we are getting rid of some conditional paths HAVE_INNODB_MMAP. Please check the backup source file too. I wonder if some backup test should have caught it,
            marko Marko Mäkelä added a comment -

            Good catch. I added test coverage of both values of the Boolean option innodb_log_file_mmap to one test of mariadb-backup --backup. Unfortunately, mariadb-backup is designed in such a way that it will silently ignore any unrecognized options.

            marko Marko Mäkelä added a comment - Good catch. I added test coverage of both values of the Boolean option innodb_log_file_mmap to one test of mariadb-backup --backup . Unfortunately, mariadb-backup is designed in such a way that it will silently ignore any unrecognized options.

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.