Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35746

support fmtlib-11.1.0

Details

    Description

      fmtlib upstream removed the ability to control locale usage via an undocumented FMT_STATIC_THOUSANDS_SEPARATOR in favor of FMT_USE_LOCALE. The issue is related to the commit https://github.com/fmtlib/fmt/commit/b3ccc2d2100052b3a3079941febf2494caa07402. This change makes the mariadb fail to configure with -DWITH_LIBFMT=system when fmtlib 11.1.0 or newer is installed in the system. See also https://bugs.gentoo.org/946924.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-35797 update bundled libfmt to 11.1.1

          • Major - Major loss of function.
          • Open
          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-36365 add lc_numeric server variable

          • Major - Major loss of function.
          • Open
          links to

          Web Link FMT_STATIC_THOUSANDS_SEPARATOR removed. Alternative?

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            serg Sergei Golubchik added a comment -

            What does https://github.com/MariaDB/server/pull/3786 have to do with the problem in the issue description? It seems to be solving something unrelated

            serg Sergei Golubchik added a comment - What does https://github.com/MariaDB/server/pull/3786 have to do with the problem in the issue description? It seems to be solving something unrelated
            serg Sergei Golubchik added a comment - - edited

            will switch fmt to use proper std::locale. The slowdown is about 30% but only if :L is specified.

            serg Sergei Golubchik added a comment - - edited will switch fmt to use proper std::locale . The slowdown is about 30% but only if :L is specified.
            svoj Sergey Vojtovich added a comment -

            I got an impression they're related after reading grooverdan's comment:

            Currently because libfmt changed the API by removing the thousands separator (fmtlib/fmt#4284) and we haven't written a compatibility for the newer libfmt yet.

            ref: https://jira.mariadb.org/browse/MDEV-35746

            But apparently they're different indeed. Do you want me to create another issue for PR#3786?

            svoj Sergey Vojtovich added a comment - I got an impression they're related after reading grooverdan's comment: Currently because libfmt changed the API by removing the thousands separator (fmtlib/fmt#4284) and we haven't written a compatibility for the newer libfmt yet. ref: https://jira.mariadb.org/browse/MDEV-35746 But apparently they're different indeed. Do you want me to create another issue for PR#3786?
            serg Sergei Golubchik added a comment - - edited

            yes, please. This one is used for fixing the separator issue

            serg Sergei Golubchik added a comment - - edited yes, please. This one is used for fixing the separator issue
            wlad Vladislav Vaintroub added a comment -

            Looks good to me

            wlad Vladislav Vaintroub added a comment - Looks good to me

            People

              serg Sergei Golubchik
              arkamar Petr Vaněk
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.