Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-35638

wsrep_last_{written,seen}_gtid call my_error(ER_OUTOFMEMORY) incorrectly.

Details

    • Bug
    • Status: Stalled (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.5.27
    • 10.5
    • Server

    Description

      my_error(ER_OUTOFMEMORY, WSREP_MAX_WSREP_SERVER_GTID_STR_LEN);

      is incorrect as there is a flags argument as the second to my_error. Also length doesn't match previous statement.

      my_error(ER_OUTOFMEMORY, MYF(0), func_name()); is incorrect as OUTOFMEMORY doesn't take a functionname

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          danblack Daniel Black created issue -
          danblack Daniel Black made changes -
          Field Original Value New Value
          Fix Version/s 10.5 [ 23123 ]
          danblack Daniel Black made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          danblack Daniel Black added a comment -

          Kristian, can I get a review on https://github.com/MariaDB/server/pull/3696 please.

          danblack Daniel Black added a comment - Kristian, can I get a review on https://github.com/MariaDB/server/pull/3696 please.
          danblack Daniel Black made changes -
          Assignee Daniel Black [ danblack ] Kristian Nielsen [ knielsen ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          knielsen Kristian Nielsen added a comment -

          Approved with comments in the PR.
          But please do in 11.4 or development branch, not old 10.5 GA.

          knielsen Kristian Nielsen added a comment - Approved with comments in the PR. But please do in 11.4 or development branch, not old 10.5 GA.
          knielsen Kristian Nielsen made changes -
          Assignee Kristian Nielsen [ knielsen ] Daniel Black [ danblack ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          vlad.radu Vlad Radu made changes -
          Labels foundation

          People

            danblack Daniel Black
            danblack Daniel Black
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.