Innochecksum wrongly reports the freed undo log as exisitng undo log pages. This gives wrong sense about undo log pages
are not being freed. To fix this issue, we introduce a new command line option
innochecksum --skip-freed-pages
or short option -r which makes innochecksum consult extent descriptor page and skip further analysis of pages that are marked as freed.
Because we can’t trust the contents of FIL_PAGE_TYPE in old InnoDB system tablespaces, I think that this logic needs to be enabled for all pages, enabled by some command line option of innochecksum, which instructs it to not report page statistics for pages that have been marked as freed.
I would also suggest another option for validating the page number and tablespace ID inside those data pages that are not filled with NUL bytes, unless such logic already exists.
Marko Mäkelä
added a comment - Because we can’t trust the contents of FIL_PAGE_TYPE in old InnoDB system tablespaces, I think that this logic needs to be enabled for all pages, enabled by some command line option of innochecksum , which instructs it to not report page statistics for pages that have been marked as freed.
I would also suggest another option for validating the page number and tablespace ID inside those data pages that are not filled with NUL bytes, unless such logic already exists.
People
Thirunarayanan Balathandayuthapani
Thirunarayanan Balathandayuthapani
Votes:
1Vote for this issue
Watchers:
4Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":983.5,"ttfb":305.60000014305115,"pageVisibility":"visible","entityId":131563,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"260ec4d1-2e43-4d0e-ac25-afcb35746f87","navigationType":0,"readyForUser":1098,"redirectCount":0,"resourceLoadedEnd":1072.1000001430511,"resourceLoadedStart":312,"resourceTiming":[{"duration":60.200000047683716,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":312,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":312,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":372.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":64.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":312.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":312.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":377.10000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":150.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":312.40000009536743,"connectEnd":312.40000009536743,"connectStart":312.40000009536743,"domainLookupEnd":312.40000009536743,"domainLookupStart":312.40000009536743,"fetchStart":312.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":312.40000009536743,"responseEnd":463,"responseStart":463,"secureConnectionStart":312.40000009536743},{"duration":227.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":312.60000014305115,"connectEnd":312.60000014305115,"connectStart":312.60000014305115,"domainLookupEnd":312.60000014305115,"domainLookupStart":312.60000014305115,"fetchStart":312.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":312.60000014305115,"responseEnd":539.7999999523163,"responseStart":539.7999999523163,"secureConnectionStart":312.60000014305115},{"duration":231.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":312.7000000476837,"connectEnd":312.7000000476837,"connectStart":312.7000000476837,"domainLookupEnd":312.7000000476837,"domainLookupStart":312.7000000476837,"fetchStart":312.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":312.7000000476837,"responseEnd":543.7999999523163,"responseStart":543.7999999523163,"secureConnectionStart":312.7000000476837},{"duration":231.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":313,"connectEnd":313,"connectStart":313,"domainLookupEnd":313,"domainLookupStart":313,"fetchStart":313,"redirectEnd":0,"redirectStart":0,"requestStart":313,"responseEnd":544.7000000476837,"responseStart":544.7000000476837,"secureConnectionStart":313},{"duration":232,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":313.10000014305115,"connectEnd":313.10000014305115,"connectStart":313.10000014305115,"domainLookupEnd":313.10000014305115,"domainLookupStart":313.10000014305115,"fetchStart":313.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":313.10000014305115,"responseEnd":545.1000001430511,"responseStart":545.1000001430511,"secureConnectionStart":313.10000014305115},{"duration":293.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":313.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":313.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":607.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":232.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":313.5,"connectEnd":313.5,"connectStart":313.5,"domainLookupEnd":313.5,"domainLookupStart":313.5,"fetchStart":313.5,"redirectEnd":0,"redirectStart":0,"requestStart":313.5,"responseEnd":545.6000001430511,"responseStart":545.6000001430511,"secureConnectionStart":313.5},{"duration":293.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":313.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":313.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":607.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":232.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":313.7999999523163,"connectEnd":313.7999999523163,"connectStart":313.7999999523163,"domainLookupEnd":313.7999999523163,"domainLookupStart":313.7999999523163,"fetchStart":313.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":313.7999999523163,"responseEnd":546.2000000476837,"responseStart":546.2000000476837,"secureConnectionStart":313.7999999523163},{"duration":537,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":314.7000000476837,"connectEnd":314.7000000476837,"connectStart":314.7000000476837,"domainLookupEnd":314.7000000476837,"domainLookupStart":314.7000000476837,"fetchStart":314.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":314.7000000476837,"responseEnd":851.7000000476837,"responseStart":851.7000000476837,"secureConnectionStart":314.7000000476837},{"duration":709.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":314.7000000476837,"connectEnd":314.7000000476837,"connectStart":314.7000000476837,"domainLookupEnd":314.7000000476837,"domainLookupStart":314.7000000476837,"fetchStart":314.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":314.7000000476837,"responseEnd":1024.4000000953674,"responseStart":1024.4000000953674,"secureConnectionStart":314.7000000476837},{"duration":232.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":619.5,"connectEnd":619.5,"connectStart":619.5,"domainLookupEnd":619.5,"domainLookupStart":619.5,"fetchStart":619.5,"redirectEnd":0,"redirectStart":0,"requestStart":619.5,"responseEnd":852,"responseStart":852,"secureConnectionStart":619.5},{"duration":155.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-jira.view.issue,-jira.navigator.kickass,-viewissue.standalone,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":916.2000000476837,"connectEnd":916.2000000476837,"connectStart":916.2000000476837,"domainLookupEnd":916.2000000476837,"domainLookupStart":916.2000000476837,"fetchStart":916.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":916.2000000476837,"responseEnd":1072.1000001430511,"responseStart":1072.1000001430511,"secureConnectionStart":916.2000000476837},{"duration":207.20000004768372,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":977.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":977.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1184.4000000953674,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":154,"responseStart":306,"responseEnd":310,"domLoading":309,"domInteractive":1142,"domContentLoadedEventStart":1142,"domContentLoadedEventEnd":1181,"domComplete":1602,"loadEventStart":1602,"loadEventEnd":1603,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1131},{"name":"bigPipe.sidebar-id.end","time":1131.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":1131.7999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1132.9000000953674},{"name":"activityTabFullyLoaded","time":1202.7000000476837}],"measures":[],"correlationId":"fb732ee6f8c0c3","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":94,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Because we can’t trust the contents of FIL_PAGE_TYPE in old InnoDB system tablespaces, I think that this logic needs to be enabled for all pages, enabled by some command line option of innochecksum, which instructs it to not report page statistics for pages that have been marked as freed.
I would also suggest another option for validating the page number and tablespace ID inside those data pages that are not filled with NUL bytes, unless such logic already exists.