Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34973

Annotate various methods with `noexcept`

Details

    Description

      As described in https://github.com/MariaDB/server/pull/3531 I suggest adding `noexcept` annotations to various methods throughout the MariaDB code base, starting with the InnoDB locking code.

      MariaDB is compiled with C++ exceptions enabled, and that disallows some optimizations (e.g. the stack must always be unwinding-safe).  By adding `noexcept` to functions that are guaranteed to never throw, some of these optimizations can be regained.  Low-level locking functions that are called often are a good candidate for this.

      Attachments

        Issue Links

          Activity

            maxk Max Kellermann created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            Labels performance
            marko Marko Mäkelä made changes -
            Fix Version/s 10.6 [ 24028 ]
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ]
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            maxk Max Kellermann made changes -
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2024-10-01 08:56:44.0 2024-10-01 08:56:44.474
            marko Marko Mäkelä made changes -
            Fix Version/s 10.6.20 [ 29903 ]
            Fix Version/s 10.11.10 [ 29904 ]
            Fix Version/s 11.2.6 [ 29906 ]
            Fix Version/s 11.4.4 [ 29907 ]
            Fix Version/s 11.6.2 [ 29908 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Issue Type New Feature [ 2 ] Task [ 3 ]
            marko Marko Mäkelä made changes -

            People

              marko Marko Mäkelä
              maxk Max Kellermann
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.