Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
11.5(EOL)
-
None
Description
e.g. https://buildbot.mariadb.org/#/builders/327/builds/23484
sys_vars.session_track_system_variables_basic w12 [ fail ]
|
Test ended at 2024-09-10 07:29:00
|
|
|
CURRENT_TEST: sys_vars.session_track_system_variables_basic
|
--- /home/buildbot/s390x-rhel-8/build/mysql-test/suite/sys_vars/r/session_track_system_variables_basic.result 2024-09-10 05:26:18.000000000 +0000
|
+++ /home/buildbot/s390x-rhel-8/build/mysql-test/suite/sys_vars/r/session_track_system_variables_basic.reject 2024-09-10 07:29:00.405736302 +0000
|
@@ -158,16 +158,16 @@
|
set global session_track_system_variables="autocommit,character_set_client,character_set_connection,redirect_url,time_zone";
|
connect foo,localhost,root;
|
-- Tracker : SESSION_TRACK_SYSTEM_VARIABLES
|
--- autocommit
|
--- ON
|
+-- redirect_url
|
+--
|
-- time_zone
|
-- SYSTEM
|
-- character_set_client
|
-- latin1
|
+-- autocommit
|
+-- ON
|
-- character_set_connection
|
-- latin1
|
--- redirect_url
|
---
|
According to danblack it could be caused by the output coming out of a hash inside the server, and that one solution is to sort the output in client/mysqltest.cc
The reason that the failure only appears after the MDEV-31609 testcase is because it was the first to output multiple variables in the session track info.
Attachments
Issue Links
- duplicates
-
-
- Closed
-
- is part of
-
MDEV-33073 always green buildbot
-
- Stalled
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Affects Version/s | 11.5 [ 29506 ] |
| Link | This issue is part of MDEV-33073 [ MDEV-33073 ] |
| Fix Version/s | 11.5 [ 29506 ] |
| Component/s | Tests [ 10800 ] |
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 11.5(EOL) [ 29506 ] |
| Assignee | Yuchen Pei [ JIRAUSER52627 ] | Daniel Black [ danblack ] |
| Status | Confirmed [ 10101 ] | In Review [ 10002 ] |
Looks good on 3c86786faed bb-10.5-mdev-34915
One improvement noted inhttps://github.com/MariaDB/server/commit/06d6a826c0320919c9ad2b20d5a1180e85430b4a#r147517296 comments to not treat "type == SESSION_TRACK_SYSTEM_VARIABLES" special. Make this the case for all trackers. This type is the only one used currently in mtr.
Approved with this change with the change.
First conflict is on 11.2 where because of fa2faf41e778 the test mysql-test/main/mysqltest_tracking_info will need a simple re-record due to format changes.
11.6 on mysql-test/suite/sys_vars/t/session_track_system_variables_basic.test, MDEV-31609 test can now omit save/restore on global.session_track_system_variables and re-record result without the comment " character_set_results as it can appear out of order in the CI" as this change fixes it.
| Assignee | Daniel Black [ danblack ] | Yuchen Pei [ JIRAUSER52627 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
Thanks for the review danblack. Addressed all comments, but no code change so ptal at the same commit as before.
| Assignee | Yuchen Pei [ JIRAUSER52627 ] | Daniel Black [ danblack ] |
| Status | Stalled [ 10000 ] | In Review [ 10002 ] |
| Assignee | Daniel Black [ danblack ] | Yuchen Pei [ JIRAUSER52627 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
thanks for the review - pushed e9c999caf48626fb565a2f888217d89065acb60b to 10.5
| Fix Version/s | 10.5.27 [ 29902 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Fix Version/s | 10.6.20 [ 29903 ] | |
| Fix Version/s | 10.11.10 [ 29904 ] | |
| Fix Version/s | 11.2.6 [ 29906 ] | |
| Fix Version/s | 11.4.4 [ 29907 ] |
| Link |
This issue duplicates |
Hi danblack, ptal thanks
3c86786faed bb-10.5-mdev-34915 MDEV-34915 Sort output of session track system variable in mysqltest