Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34819

THD::save_prep_leaf_tables is unused

    XMLWordPrintable

Details

    Description

      As observed by psergei:

      https://gist.github.com/spetrunia/109a4edee21a0aeb4802e37b1d29bc5a

      Started after MDEV-28883.

      Attempts to remove this field cascaded to the removal of an else branch as well as an enum SELECT_LEX:SAVED, see bb-11.1-remove-save-prep-leaf-tables / bb-11.6-remove-save-prep-leaf-tables, so it may need some further attention to decide whether it is ok to remove or whether MDEV-28883 missed something.

      Attachments

        Issue Links

          is caused by

          Technical task - A technical task. MDEV-28883 Re-design the upper level of handling UPDATE and DELETE statements

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35402 Dead code: save_prep_leaf_tables() functions and leaf_tables_prep

          • Major - Major loss of function.
          • Confirmed

          Activity

            People

              Unassigned Unassigned
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.