[MDEV-34704] Quick mode produces the bug for mariadb client - Jira

Details

Type: New Feature
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Fix Version/s: 10.5.27, 10.6.20, 10.11.10, 11.4.4, 11.6.2
Component/s: Scripts & Clients
Labels:
- client

Description

For the quick mode we need the option to limit width of the column for printing the data
current behavior makes interactive console unusable

Attachments

Issue Links

blocks

MCOL-5587 Columnstore crashes/unstable on too large selects

Closed

causes

MDEV-34831 MDEV-34704 introduces a typo, --qick

Closed

Activity

Ascending order - Click to sort in descending order

Leonid Fedorov created issue - 2024-07-30 14:12

Leonid Fedorov made changes - 2024-07-30 14:17

Field	Original Value	New Value
Description		After config option added {code} [mariadb-client] quick {code} simple query {code} create table t(a text) engine; insert into t values('xyz'); select * from t; {code} produces stream of dashes that make console unusable {code} MariaDB [test]> select * from t; +---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- {code} in the print table code {code} static void print_table_data(MYSQL_RES result) { String separator(256); MYSQL_ROW cur; bool num_flag; num_flag=(bool) my_alloca(sizeof(bool)mysql_num_fields(result)); if (column_types_flag) { print_field_types(result); if (!mysql_num_rows(result)) { my_afree((uchar) num_flag); return; } mysql_field_seek(result,0); } separator.copy("+",1,charset_info); while (MYSQL_FIELD field= mysql_fetch_field(result)) { uint length= column_names ? field->name_length : 0; if (quick) length= MY_MAX(length,field->length); else length= MY_MAX(length,field->max_length); if (length < 4 && !IS_NOT_NULL(field->flags)) length=4; // Room for "NULL" {code} I could see the length calculated as MY_MAX(length,field->length); accepts the value of several thousands

Leonid Fedorov made changes - 2024-07-30 14:18

Link

This issue blocks ~~MCOL-5587~~ [ ~~MCOL-5587~~ ]

Leonid Fedorov made changes - 2024-07-30 14:18

Priority

Major [ 3 ]

Critical [ 2 ]

Leonid Fedorov made changes - 2024-07-30 14:18

Affects Version/s

10.6.18-14 [ 29820 ]

Leonid Fedorov made changes - 2024-07-30 14:19

Component/s

Server [ 14979 ]

Julien Fritsch made changes - 2024-07-30 14:55

Component/s

Scripts & Clients [ 14977 ]

Julien Fritsch made changes - 2024-07-30 14:55

Component/s

ColumnStore [ 15602 ]

Julien Fritsch made changes - 2024-07-30 14:55

Labels

client

Julien Fritsch made changes - 2024-07-30 14:56

Assignee

Oleksandr Byelkin [ sanja ]

Sergei Golubchik made changes - 2024-07-30 16:18

Component/s	ColumnStore [ 15602 ]
Component/s	Server [ 14979 ]
Fix Version/s		N/A [ 23617 ]
Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Resolution		Not a Bug [ 6 ]
Status	Open [ 1 ]	Closed [ 6 ]

Leonid Fedorov made changes - 2024-07-31 12:58

Issue Type

Bug [ 1 ]

New Feature [ 2 ]

Leonid Fedorov made changes - 2024-07-31 12:59

Description

After config option added
{code}
[mariadb-client]
quick
{code}

simple query
{code}
create table t(a text) engine;
insert into t values('xyz');
select * from t;
{code}

produces stream of dashes that make console unusable
{code}
MariaDB [test]> select * from t;
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
{code}

in the print table code
{code}
static void
print_table_data(MYSQL_RES *result)
{
  String separator(256);
  MYSQL_ROW cur;
  bool *num_flag;

  num_flag=(bool*) my_alloca(sizeof(bool)*mysql_num_fields(result));
  if (column_types_flag)
  {
    print_field_types(result);
    if (!mysql_num_rows(result))
    {
      my_afree((uchar*) num_flag);
      return;
    }
    mysql_field_seek(result,0);
  }
  separator.copy("+",1,charset_info);
  while (MYSQL_FIELD *field= mysql_fetch_field(result))
  {
    uint length= column_names ? field->name_length : 0;
    if (quick)
      length= MY_MAX(length,field->length);
    else
      length= MY_MAX(length,field->max_length);
    if (length < 4 && !IS_NOT_NULL(field->flags))
      length=4; // Room for "NULL"
{code}

I could see the length calculated as MY_MAX(length,field->length); accepts the value of several thousands

For the quick mode we need the option to limit width of the column for printing the data
current behavior makes interactive console unusable

Leonid Fedorov made changes - 2024-07-31 12:59

Resolution	Not a Bug [ 6 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Julien Fritsch made changes - 2024-07-31 13:11

Fix Version/s		10.6 [ 24027 ]
Fix Version/s	N/A [ 23617 ]

Julien Fritsch made changes - 2024-07-31 13:11

Assignee

Sergei Golubchik [ serg ]

Oleksandr Byelkin [ sanja ]

Ralf Gebhardt made changes - 2024-08-02 12:44

Summary

Quick mode produces the bug for mariadb cliend

Quick mode produces the bug for mariadb client

Ralf Gebhardt made changes - 2024-08-05 07:49

Component/s		Scripts & Clients [ 11002 ]
Component/s	Scripts & Clients [ 14977 ]
Fix Version/s		11.7 [ 29815 ]
Fix Version/s	10.6 [ 24027 ]
Key	~~MENT-2103~~	~~MDEV-34704~~
Affects Version/s	10.6.18-14 [ 29820 ]
Project	MariaDB Enterprise [ 11500 ]	MariaDB Server [ 10000 ]

Oleksandr Byelkin made changes - 2024-08-05 12:30

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Oleksandr Byelkin added a comment - 2024-08-05 14:31

commit 186aa192d1ffcd3bbcdc187d764434c0440cc39e (HEAD -> bb-11.6-MDEV-34704)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Mon Aug 5 16:16:09 2024 +0200

    MDEV-34704 Quick mode produces the bug for mariadb client

      --quick-max-column-width parameter added to limit field

        width in --quick mode.

Oleksandr Byelkin added a comment - 2024-08-05 14:31 commit 186aa192d1ffcd3bbcdc187d764434c0440cc39e (HEAD -> bb-11.6-MDEV-34704) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Aug 5 16:16:09 2024 +0200 MDEV-34704 Quick mode produces the bug for mariadb client --quick-max-column-width parameter added to limit field width in --quick mode.

Oleksandr Byelkin made changes - 2024-08-05 15:08

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik made changes - 2024-08-22 15:40

Assignee	Sergei Golubchik [ serg ]	Oleksandr Byelkin [ sanja ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2024-08-27 05:45

Status

Stalled [ 10000 ]

In Testing [ 10301 ]

Oleksandr Byelkin made changes - 2024-08-27 05:45

Assignee

Oleksandr Byelkin [ sanja ]

Ramesh Sivaraman [ JIRAUSER48189 ]

Oleksandr Byelkin added a comment - 2024-08-27 07:02

commit 7465bc6d430b561c8edc826699f0cd541ac20416 (HEAD -> bb-11.7-MDEV-34704, origin/bb-11.7-MDEV-34704)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Mon Aug 5 16:16:09 2024 +0200

    MDEV-34704 Quick mode produces the bug for mariadb client

      --quick-max-column-width parameter added to limit field

        width in --quick mode.

Oleksandr Byelkin added a comment - 2024-08-27 07:02 commit 7465bc6d430b561c8edc826699f0cd541ac20416 (HEAD -> bb-11.7-MDEV-34704, origin/bb-11.7-MDEV-34704) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Aug 5 16:16:09 2024 +0200 MDEV-34704 Quick mode produces the bug for mariadb client --quick-max-column-width parameter added to limit field width in --quick mode.

Ramesh Sivaraman added a comment - 2024-08-27 12:32

test looks good. okay to push

Ramesh Sivaraman added a comment - 2024-08-27 12:32 test looks good. okay to push

Ramesh Sivaraman made changes - 2024-08-27 12:32

Assignee	Ramesh Sivaraman [ JIRAUSER48189 ]	Oleksandr Byelkin [ sanja ]
Status	In Testing [ 10301 ]	Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2024-08-27 14:36

issue.field.resolutiondate

2024-08-27 14:36:25.0

2024-08-27 14:36:24.597

Oleksandr Byelkin made changes - 2024-08-27 14:36

Fix Version/s		11.7.0 [ 29912 ]
Fix Version/s	11.7 [ 29815 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Oleksandr Byelkin made changes - 2024-08-28 17:04

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2024-08-28 18:30

Fix Version/s		10.5.27 [ 29902 ]
Fix Version/s	11.7.0 [ 29912 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Oleksandr Byelkin made changes - 2024-08-28 18:40

Fix Version/s		10.6.20 [ 29903 ]
Fix Version/s		10.11.10 [ 29904 ]
Fix Version/s		11.4.4 [ 29907 ]
Fix Version/s		11.6.2 [ 29908 ]
Fix Version/s		11.7.1 [ 29913 ]

Ian Gilfillan made changes - 2024-08-28 20:03

Link

This issue causes ~~MDEV-34831~~ [ ~~MDEV-34831~~ ]

Sergei Golubchik made changes - 2024-09-03 14:30

Fix Version/s

11.7.1 [ 29913 ]

People

Assignee:: Oleksandr Byelkin

Reporter:: Leonid Fedorov

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2024-07-30 14:12

Updated:: 2024-10-03 16:12

Resolved:: 2024-08-28 18:30

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration