[MDEV-34340] mariadb-backup immediately dumps core - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.11.7, 10.11.8
Fix Version/s: 10.5.27, 10.6.20, 10.11.10, 11.2.6, 11.4.4
Component/s: Scripts & Clients
Labels:
None
Environment:
NetBSD 10.0/amd64

Description

When I run mariadb-backup, it immediately dumps core:

# mariadb-backup

Memory fault (core dumped)

If I run it from the directory where it's installed (/usr/pkg/bin), it prints its help successfully:

# cd /usr/pkg/bin

# mariadb-backup

mariadb-backup based on MariaDB server 10.11.8-MariaDB NetBSD (x86_64)

Open source backup tool for InnoDB and XtraDB

Copyright (C) 2009-2015 Percona LLC and/or its affiliates.

Portions Copyright (C) 2000, 2011, MySQL AB & Innobase Oy.

Portions Copyright (C) 2017-2023 MariaDB Corporation / MariaDB Plc.

Attachments

Issue Links

is caused by

MDEV-13466 Implement --export option for MariaDB Backup

Closed

Activity

Ascending order - Click to sort in descending order

Thomas Klausner created issue - 2024-06-08 01:11

Marko Mäkelä added a comment - 2024-06-10 04:59

Can you provide some information from the core dump? In https://mariadb.com/kb/en/how-to-produce-a-full-stack-trace-for-mariadbd/ you can find some advice. You would have to replace mariadbd with mariadbd-backup when reading that.

Maybe you can just prepend gdb -ex run --args to your invocation of mariadb-backup? Then the crash should occur inside the debugger.

Marko Mäkelä added a comment - 2024-06-10 04:59 Can you provide some information from the core dump? In https://mariadb.com/kb/en/how-to-produce-a-full-stack-trace-for-mariadbd/ you can find some advice. You would have to replace mariadbd with mariadbd-backup when reading that. Maybe you can just prepend gdb -ex run --args to your invocation of mariadb-backup ? Then the crash should occur inside the debugger.

Marko Mäkelä made changes - 2024-06-10 04:59

Field	Original Value	New Value
Status	Open [ 1 ]	Needs Feedback [ 10501 ]

Thomas Klausner added a comment - 2024-06-10 07:04

A backtrace of the core dump file is quite short:

{{(gdb) bt
#0 0x000000012af2d064 in my_realpath ()
#1 0x000000012b013332 in main ()}}

Thomas Klausner added a comment - 2024-06-10 07:04 A backtrace of the core dump file is quite short: {{(gdb) bt #0 0x000000012af2d064 in my_realpath () #1 0x000000012b013332 in main ()}}

Sergei Golubchik made changes - 2024-07-09 12:32

Assignee

Daniel Black [ danblack ]

Sergei Golubchik added a comment - 2024-07-09 12:33

Thanks. It must be caused by ~~MDEV-29582~~ then.

Sergei Golubchik added a comment - 2024-07-09 12:33 Thanks. It must be caused by MDEV-29582 then.

Sergei Golubchik made changes - 2024-07-09 12:33

Status

Needs Feedback [ 10501 ]

Open [ 1 ]

Sergei Golubchik made changes - 2024-07-09 12:33

Description

When I run mariadb-backup, it immediately dumps core:
```
# mariadb-backup Memory fault (core dumped)
```
If I run it from the directory where it's installed (/usr/pkg/bin), it prints its help successfully:
```
# cd /usr/pkg/bin
# mariadb-backup
mariadb-backup based on MariaDB server 10.11.8-MariaDB NetBSD (x86_64)
Open source backup tool for InnoDB and XtraDB

Copyright (C) 2009-2015 Percona LLC and/or its affiliates.
Portions Copyright (C) 2000, 2011, MySQL AB & Innobase Oy.
Portions Copyright (C) 2017-2023 MariaDB Corporation / MariaDB Plc.
...
```

When I run mariadb-backup, it immediately dumps core:
{noformat}
# mariadb-backup Memory fault (core dumped)
{noformat}If I run it from the directory where it's installed (/usr/pkg/bin), it prints its help successfully:
{noformat}
# cd /usr/pkg/bin
# mariadb-backup
mariadb-backup based on MariaDB server 10.11.8-MariaDB NetBSD (x86_64)
Open source backup tool for InnoDB and XtraDB

Copyright (C) 2009-2015 Percona LLC and/or its affiliates.
Portions Copyright (C) 2000, 2011, MySQL AB & Innobase Oy.
Portions Copyright (C) 2017-2023 MariaDB Corporation / MariaDB Plc.
{noformat}

Sergei Golubchik made changes - 2024-07-09 12:34

Description

When I run mariadb-backup, it immediately dumps core:
{noformat}
# mariadb-backup
Memory fault (core dumped)
{noformat}If I run it from the directory where it's installed (/usr/pkg/bin), it prints its help successfully:
{noformat}
# cd /usr/pkg/bin
# mariadb-backup
mariadb-backup based on MariaDB server 10.11.8-MariaDB NetBSD (x86_64)
Open source backup tool for InnoDB and XtraDB

Copyright (C) 2009-2015 Percona LLC and/or its affiliates.
Portions Copyright (C) 2000, 2011, MySQL AB & Innobase Oy.
Portions Copyright (C) 2017-2023 MariaDB Corporation / MariaDB Plc.
{noformat}

Sergei Golubchik made changes - 2024-07-09 12:34

Link

This issue is caused by ~~MDEV-29582~~ [ ~~MDEV-29582~~ ]

Sergei Golubchik made changes - 2024-07-09 12:34

Component/s		Scripts & Clients [ 11002 ]
Component/s	Backup [ 13902 ]

Daniel Black added a comment - 2024-08-19 00:57

~~MDEV-13466~~ adds the call in mariabackup to my_realpath via get_exepath.

wiz, feel like contributing a fix on extra/mariabackup/xtrabackup.cc:get_exepath on 10.5 for NetBSD and maybe other missing OSes - (ref: https://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe)

Daniel Black added a comment - 2024-08-19 00:57 MDEV-13466 adds the call in mariabackup to my_realpath via get_exepath. wiz , feel like contributing a fix on extra/mariabackup/xtrabackup.cc:get_exepath on 10.5 for NetBSD and maybe other missing OSes - (ref: https://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe )

Daniel Black made changes - 2024-08-19 00:57

Link

This issue is caused by ~~MDEV-13466~~ [ ~~MDEV-13466~~ ]

Daniel Black made changes - 2024-08-19 00:57

Fix Version/s		10.5 [ 23123 ]
Fix Version/s		10.11 [ 27614 ]

Daniel Black made changes - 2024-08-19 00:58

Link

This issue is caused by ~~MDEV-29582~~ [ ~~MDEV-29582~~ ]

Sergei Golubchik made changes - 2024-08-19 08:36

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Golubchik added a comment - 2024-08-19 08:37

danblack, please, create a reusable function for this in mysys, so that ~~MDEV-29582~~ could use it too

Sergei Golubchik added a comment - 2024-08-19 08:37 danblack , please, create a reusable function for this in mysys, so that MDEV-29582 could use it too

Thomas Klausner added a comment - 2024-08-19 09:08

Thank you for the pointer, Daniel Black!
The following diff against 10.11.9 adds support for this, and with it, mariadb-backup does not dump core on startup any longer:

--- extra/mariabackup/xtrabackup.cc.orig        2024-08-03 07:29:56.000000000 +0000

+++ extra/mariabackup/xtrabackup.cc

@@ -69,6 +69,11 @@ Street, Fifth Floor, Boston, MA 02110-13

 # include <sys/sysctl.h>

 #endif

+#ifdef __NetBSD__

+# include <sys/param.h>

+# include <sys/sysctl.h>

+#endif

 #include "aria_backup_client.h"

 #include <btr0sea.h>

@@ -7690,6 +7695,11 @@ static int get_exepath(char *buf, size_t

   if (sysctl(mib, 4, buf, &size, NULL, 0) == 0) {

     return 0;

+#elif defined(__NetBSD__)

+  int mib[4] = {CTL_KERN, KERN_PROC_ARGS, -1, KERN_PROC_PATHNAME };

+  if (sysctl(mib, 4, buf, &size, NULL, 0) == 0) {

+    return 0;

+  }

 #endif

   return my_realpath(buf, argv0, 0);

Thomas Klausner added a comment - 2024-08-19 09:08 Thank you for the pointer, Daniel Black! The following diff against 10.11.9 adds support for this, and with it, mariadb-backup does not dump core on startup any longer: --- extra/mariabackup/xtrabackup.cc.orig 2024-08-03 07:29:56.000000000 +0000 +++ extra/mariabackup/xtrabackup.cc @@ -69,6 +69,11 @@ Street, Fifth Floor, Boston, MA 02110-13 # include <sys/sysctl.h> #endif +#ifdef __NetBSD__ +# include <sys/param.h> +# include <sys/sysctl.h> +#endif + #include "aria_backup_client.h" #include <btr0sea.h> @@ -7690,6 +7695,11 @@ static int get_exepath( char *buf, size_t if (sysctl(mib, 4, buf, &size, NULL, 0) == 0) { return 0; } +#elif defined(__NetBSD__) + int mib[4] = {CTL_KERN, KERN_PROC_ARGS, -1, KERN_PROC_PATHNAME }; + if (sysctl(mib, 4, buf, &size, NULL, 0) == 0) { + return 0; + } #endif return my_realpath(buf, argv0, 0);

Daniel Black made changes - 2024-09-24 03:13

Status

Open [ 1 ]

In Progress [ 3 ]

Daniel Black made changes - 2024-09-24 03:14

Assignee	Daniel Black [ danblack ]	Andrew Hutchings [ JIRAUSER52179 ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Daniel Black added a comment - 2024-09-24 03:14

Thanks wiz for your implementation. I've included it in https://github.com/MariaDB/server/pull/3545.

Daniel Black added a comment - 2024-09-24 03:14 Thanks wiz for your implementation. I've included it in https://github.com/MariaDB/server/pull/3545 .

Andrew Hutchings (Inactive) made changes - 2024-09-30 13:27

Fix Version/s		10.5.27 [ 29902 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.11 [ 27614 ]
Resolution		Fixed [ 1 ]
Status	In Review [ 10002 ]	Closed [ 6 ]

JiraAutomate made changes - 2024-09-30 13:27

Fix Version/s		10.6.20 [ 29903 ]
Fix Version/s		10.11.10 [ 29904 ]
Fix Version/s		11.2.6 [ 29906 ]
Fix Version/s		11.4.4 [ 29907 ]

Andrew Hutchings (Inactive) made changes - 2024-09-30 13:27

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Stalled [ 10000 ]

Andrew Hutchings (Inactive) made changes - 2024-09-30 13:27

Status

Stalled [ 10000 ]

In Review [ 10002 ]

Andrew Hutchings (Inactive) made changes - 2024-09-30 13:27

Fix Version/s		10.5 [ 23123 ]
Fix Version/s	10.5.27 [ 29902 ]
Fix Version/s	10.6.20 [ 29903 ]
Fix Version/s	10.11.10 [ 29904 ]
Fix Version/s	11.2.6 [ 29906 ]
Fix Version/s	11.4.4 [ 29907 ]

Andrew Hutchings (Inactive) added a comment - 2024-09-30 13:27

Accidentally closed the wrong ticket, reopened.

Andrew Hutchings (Inactive) added a comment - 2024-09-30 13:27 Accidentally closed the wrong ticket, reopened.

Andrew Hutchings (Inactive) made changes - 2024-10-08 07:05

Assignee	Andrew Hutchings [ JIRAUSER52179 ]	Daniel Black [ danblack ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Daniel Black made changes - 2024-10-16 02:11

issue.field.resolutiondate

2024-10-16 02:11:13.0

2024-10-16 02:11:13.207

Daniel Black made changes - 2024-10-16 02:11

Fix Version/s		10.5.27 [ 29902 ]
Fix Version/s	10.5 [ 23123 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

JiraAutomate made changes - 2024-10-16 02:11

Fix Version/s		10.6.20 [ 29903 ]
Fix Version/s		10.11.10 [ 29904 ]
Fix Version/s		11.2.6 [ 29906 ]
Fix Version/s		11.4.4 [ 29907 ]

People

Assignee:: Daniel Black

Reporter:: Thomas Klausner

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2024-06-08 01:11

Updated:: 2024-10-16 02:11

Resolved:: 2024-10-16 02:11

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration